From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id A91931FF142 for ; Fri, 03 Jul 2026 13:54:39 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D9EBA21210; Fri, 03 Jul 2026 13:54:38 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 1/3] api: disk import: remove unused wrongly named variable Date: Fri, 3 Jul 2026 13:54:16 +0200 Message-ID: <20260703115432.108667-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260703115432.108667-1-f.ebner@proxmox.com> References: <20260703115432.108667-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783079667580 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: U34GWZ34IB6ZEQ4PSUJN6IBSKIKL4H3Q X-Message-ID-Hash: U34GWZ34IB6ZEQ4PSUJN6IBSKIKL4H3Q X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The result from parse_volume_id() is the storage ID and the volume name. Its input is the volume ID. Signed-off-by: Fiona Ebner Tested-by: Manuel Federanko Reviewed-by: Dominik Csapak --- src/PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index 9023c344..e575d36b 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -499,7 +499,7 @@ my sub create_disks : prototype($$$$$$$$$$$) { $needs_creation = $live_import; - my ($source_storage, $source_volid) = PVE::Storage::parse_volume_id($source, 1); + my ($source_storage) = PVE::Storage::parse_volume_id($source, 1); if ($source_storage) { # PVE-managed volume my ($vtype, $source_format) = -- 2.47.3