From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 840B21FF142 for ; Fri, 03 Jul 2026 12:48:33 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 53CAB212D7; Fri, 03 Jul 2026 12:48:33 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH network 1/2] prefix specific sdn resource type to existence assertion string Date: Fri, 3 Jul 2026 12:47:49 +0200 Message-ID: <20260703104750.117988-2-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260703104750.117988-1-d.kral@proxmox.com> References: <20260703104750.117988-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783075669401 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5IIOSGUSXRFVXXURZWXRIQOAIJ45FAGA X-Message-ID-Hash: 5IIOSGUSXRFVXXURZWXRIQOAIJ45FAGA X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The non-empty assertion strings already prefixed each sdn resource type, but the existence assertion did not. This makes error messages more clearer if multiple sdn resources are provided, e.g. as API parameters by users. Signed-off-by: Daniel Kral --- src/PVE/Network/SDN/Controllers.pm | 2 +- src/PVE/Network/SDN/Dns.pm | 2 +- src/PVE/Network/SDN/Ipams.pm | 2 +- src/PVE/Network/SDN/Zones.pm | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/PVE/Network/SDN/Controllers.pm b/src/PVE/Network/SDN/Controllers.pm index 4336b86..b2c2f9d 100644 --- a/src/PVE/Network/SDN/Controllers.pm +++ b/src/PVE/Network/SDN/Controllers.pm @@ -28,7 +28,7 @@ sub sdn_controllers_config { die "no sdn controller ID specified\n" if !$id; my $scfg = $cfg->{ids}->{$id}; - die "sdn '$id' does not exist\n" if (!$noerr && !$scfg); + die "sdn controller '$id' does not exist\n" if (!$noerr && !$scfg); return $scfg; } diff --git a/src/PVE/Network/SDN/Dns.pm b/src/PVE/Network/SDN/Dns.pm index 76833ea..db2f930 100644 --- a/src/PVE/Network/SDN/Dns.pm +++ b/src/PVE/Network/SDN/Dns.pm @@ -21,7 +21,7 @@ sub sdn_dns_config { die "no sdn dns ID specified\n" if !$id; my $scfg = $cfg->{ids}->{$id}; - die "sdn '$id' does not exist\n" if (!$noerr && !$scfg); + die "sdn dns '$id' does not exist\n" if (!$noerr && !$scfg); return $scfg; } diff --git a/src/PVE/Network/SDN/Ipams.pm b/src/PVE/Network/SDN/Ipams.pm index 00aa20c..179bdf7 100644 --- a/src/PVE/Network/SDN/Ipams.pm +++ b/src/PVE/Network/SDN/Ipams.pm @@ -93,7 +93,7 @@ sub sdn_ipams_config { die "no sdn ipam ID specified\n" if !$id; my $scfg = $cfg->{ids}->{$id}; - die "sdn '$id' does not exist\n" if (!$noerr && !$scfg); + die "sdn ipam '$id' does not exist\n" if (!$noerr && !$scfg); return $scfg; } diff --git a/src/PVE/Network/SDN/Zones.pm b/src/PVE/Network/SDN/Zones.pm index 4c1468c..f668303 100644 --- a/src/PVE/Network/SDN/Zones.pm +++ b/src/PVE/Network/SDN/Zones.pm @@ -35,7 +35,7 @@ sub sdn_zones_config { die "no sdn zone ID specified\n" if !$id; my $scfg = $cfg->{ids}->{$id}; - die "sdn '$id' does not exist\n" if (!$noerr && !$scfg); + die "sdn zone '$id' does not exist\n" if (!$noerr && !$scfg); return $scfg; } -- 2.47.3