From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 4B2E21FF142 for ; Fri, 03 Jul 2026 12:48:02 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3DC3021387; Fri, 03 Jul 2026 12:48:01 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH-SERIES network 0/2] assert vnet zone exists on create and update Date: Fri, 3 Jul 2026 12:47:48 +0200 Message-ID: <20260703104750.117988-1-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783075669345 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SYN5KLLCJ2GADQMTV6JVNQOKLERJS7HN X-Message-ID-Hash: SYN5KLLCJ2GADQMTV6JVNQOKLERJS7HN X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: If a VNet is created or updated with an empty zone '' or a non-existing zone identifier, the API handler will die with a slighly confusing error message: create sdn vnet object failed: cannot lookup undefined type! at /usr/share/perl5/PVE/API2/Network/SDN/Vnets.pm line 326. Therefore, use the helper sdn_zones_config(), which asserts whether the zone identifier is non-empty and existing. Daniel Kral (2): prefix specific sdn resource type to existence assertion string api: vnets: assert vnet zone exists on create and update src/PVE/API2/Network/SDN/Vnets.pm | 8 ++++---- src/PVE/Network/SDN/Controllers.pm | 2 +- src/PVE/Network/SDN/Dns.pm | 2 +- src/PVE/Network/SDN/Ipams.pm | 2 +- src/PVE/Network/SDN/Zones.pm | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) -- 2.47.3