From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 514911FF135 for ; Thu, 02 Jul 2026 12:32:35 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 32C6C2147F; Thu, 02 Jul 2026 12:32:22 +0200 (CEST) From: Jakob Klocker To: pve-devel@lists.proxmox.com Subject: [PATCH guest-common/manager/qemu-server v3 0/3] fix #5032: add guest time sync via QGA Date: Thu, 2 Jul 2026 12:31:58 +0200 Message-ID: <20260702103201.164567-1-j.klocker@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: NA4FFH63EH7RZKDS3KFLP33NLGYMDCG6 X-Message-ID-Hash: NA4FFH63EH7RZKDS3KFLP33NLGYMDCG6 X-MailFrom: jklocker@dev.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jakob Klocker X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This series adds a new agent option 'sync-time-on-resume' to automatically synchronize the guest clock via the QEMU Guest Agent after operations that can leave the guest time stale. The option is disabled by default and only takes effect when the QEMU Guest Agent is enabled. When a VM resumes with a restored RAM state (waking from hibernation or rolling back to a snapshot that includes RAM), the guest clock continues from the point the state was saved and no longer matches wall-clock time. Skews also appears whenever the guest is briefly frozen and resumed - after creating a snapshot, an ordinary pause/resume, or the resume step of a live migration. When enabled, the option triggers a guest-set-time call: * after resuming from hibernation (suspend-to-disk) * after rolling back to a snapshot that includes RAM * after a live migration * after an ordinary pause/resume * after taking a snapshot The start, resume and rollback API endpoints also accept a 'sync-time-on-resume' parameter that overrides the configured value for a single operation. The persistent config option is exposed in the QEMU Guest Agent configuration GUI, so it can be toggled per guest. Link: https://bugzilla.proxmox.com/show_bug.cgi?id=5032 changes from v1 to v2 (thanks @Arthur) - qemu: adapt warning message in the resume-from-saved-state path - ui: reword the agent option label for clarity changes from v2 to v3 (thanks @Fiona) - add sync on pause/resume - add override options - add print task - adapt formating and naming pve-guest-common: Jakob Klocker (1): AbstractConfig: allow passing options to snapshot_rollback src/PVE/AbstractConfig.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) pve-manager: Jakob Klocker (1): fix #5032: ui: qemu agent: add sync-time-on-resume option www/manager6/form/AgentFeatureSelector.js | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) qemu-server: Jakob Klocker (1): fix #5032: agent: sync guest time via QGA when the clock falls behind src/PVE/API2/Qemu.pm | 46 ++++++++++++++++++++++++++--- src/PVE/CLI/qm.pm | 2 +- src/PVE/QemuConfig.pm | 12 ++++++-- src/PVE/QemuMigrate.pm | 2 ++ src/PVE/QemuServer.pm | 18 +++++++++++- src/PVE/QemuServer/Agent.pm | 54 ++++++++++++++++++++++++++++++++++ src/PVE/QemuServer/RunState.pm | 11 ++++++- 7 files changed, 136 insertions(+), 9 deletions(-) Summary over all repositories: 9 files changed, 156 insertions(+), 12 deletions(-) -- Generated by murpp 0.12.0