From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 278001FF13E for ; Wed, 01 Jul 2026 16:14:50 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id AEC38214D3; Wed, 01 Jul 2026 16:14:15 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v10 07/10] adapt linked clone check to not die if an error occurs during check Date: Wed, 1 Jul 2026 16:13:36 +0200 Message-ID: <20260701141339.181276-8-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260701141339.181276-1-m.koeppl@proxmox.com> References: <20260701141339.181276-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782915215930 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QBUBFCI7LDYBHVHM67IFXISAT6LJ64FS X-Message-ID-Hash: QBUBFCI7LDYBHVHM67IFXISAT6LJ64FS X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Align error handling behavior when checking for linked clones with the rest of destroy_vm's error handling approach. In case an error occurred, a warning is printed and the execution continues, since: 1. The same validation occurs later in the process 2. The VM removal will still be blocked if the volume has linked clones Originally-by: Stefan Hrdlicka [ MK: log_warn if check fails instead of ignoring resolve style nits ] Signed-off-by: Michael Köppl --- src/PVE/QemuServer.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index cdf66e89..50fd66a5 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -1838,8 +1838,11 @@ sub destroy_vm { my $volid = $drive->{file}; return if !$volid || $volid =~ m|^/|; - die "base volume '$volid' is still in use by linked cloned\n" - if PVE::Storage::volume_is_base_and_used($storecfg, $volid); + my $result = eval { PVE::Storage::volume_is_base_and_used($storecfg, $volid) }; + # early check, removal of volume will fail later anyway, so warning here is fine + log_warn("failed to check if volume '$volid' is used by linked clones: $@") + if $@; + die "base volume '$volid' is still in use by linked cloned\n" if $result; }, ); -- 2.47.3