From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id A7EEB1FF13E for ; Wed, 01 Jul 2026 16:13:45 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C5FE6213A3; Wed, 01 Jul 2026 16:13:44 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH container v10 01/10] fix #3711: warn about storage errors during mountpoint delete Date: Wed, 1 Jul 2026 16:13:30 +0200 Message-ID: <20260701141339.181276-2-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260701141339.181276-1-m.koeppl@proxmox.com> References: <20260701141339.181276-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782915215388 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NR7MCZDMCOFSOOU3L5L3GQJ5FH5DB6KH X-Message-ID-Hash: NR7MCZDMCOFSOOU3L5L3GQJ5FH5DB6KH X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Errors during deletion of a mountpoint volume should not stop users from destroying a container. Instead of failing, a warning is printed and the destruction of the container continues. Reviewed-by: Fiona Ebner Originally-by: Stefan Hrdlicka [ MK: remove ignore-storage-errors param ] Signed-off-by: Michael Köppl --- src/PVE/LXC.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index a9e9be9a..aa5ff315 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1032,7 +1032,8 @@ sub destroy_lxc_container { return if $volids->{$volume}; $volids->{$volume} = 1; - delete_mountpoint_volume($storage_cfg, $vmid, $volume); + eval { delete_mountpoint_volume($storage_cfg, $vmid, $volume); }; + PVE::RESTEnvironment::log_warn("failed to delete mountpoint volume $volume: $@") if $@; }; PVE::LXC::Config->foreach_volume_full($conf, { include_unused => 1 }, $remove_volume); -- 2.47.3