From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id AA2E31FF13E for ; Wed, 01 Jul 2026 16:14:04 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 70F2521465; Wed, 01 Jul 2026 16:13:46 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v10 09/10] destroy_vm: use log_warn for vdisk_free errors for consistency Date: Wed, 1 Jul 2026 16:13:38 +0200 Message-ID: <20260701141339.181276-10-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260701141339.181276-1-m.koeppl@proxmox.com> References: <20260701141339.181276-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782915216051 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: APNJHCUCMU3IN43NY3SLGENTLW2CY6OT X-Message-ID-Hash: APNJHCUCMU3IN43NY3SLGENTLW2CY6OT X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: To make warnings visually consistent with the handling of other storage errors in destroy_vm(), replace the use of warn with log_warn. Reviewed-by: Fiona Ebner Signed-off-by: Michael Köppl --- src/PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index b69af937..3fb499a9 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -1863,7 +1863,7 @@ sub destroy_vm { $volids->{$volid} = 1; eval { PVE::Storage::vdisk_free($storecfg, $volid) }; - warn "Could not remove disk '$volid', check manually: $@" if $@; + log_warn("Could not remove disk '$volid', check manually: $@") if $@; }; # only remove disks owned by this VM (referenced in the config) @@ -1889,7 +1889,7 @@ sub destroy_vm { sub { my ($volid, $sid, $volname, $d) = @_; eval { PVE::Storage::vdisk_free($storecfg, $volid) }; - warn $@ if $@; + log_warn($@) if $@; }, ); } -- 2.47.3