From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 23A471FF138 for ; Mon, 29 Jun 2026 16:05:23 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0E87121461; Mon, 29 Jun 2026 16:05:17 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v9 08/10] fix #3711: make removal of VM possible if store does not exist anymore Date: Mon, 29 Jun 2026 16:04:37 +0200 Message-ID: <20260629140439.184878-9-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260629140439.184878-1-m.koeppl@proxmox.com> References: <20260629140439.184878-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782741871749 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5R7DJVG6HRUTNG4KB3YRIL6FGVDA6F6K X-Message-ID-Hash: 5R7DJVG6HRUTNG4KB3YRIL6FGVDA6F6K X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Similar to the handling of storage errors in other parts of destroy_vm(), an error during the call to PVE::Storage::path() should not stop the VM from being destroyed. Instead, the user should be warned and the function should continue. Originally-by: Stefan Hrdlicka [ MK: log_warn if check fails instead of ignoring error ] Signed-off-by: Michael Köppl --- src/PVE/QemuServer.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index ed5bca0c..123a357d 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -1856,7 +1856,8 @@ sub destroy_vm { return if !$volid || $volid =~ m|^/|; return if $volids->{$volid}; - my ($path, $owner) = PVE::Storage::path($storecfg, $volid); + my ($path, $owner) = eval { PVE::Storage::path($storecfg, $volid) }; + log_warn("failed to get path and owner of volume '$volid': $@") if $@; return if !$path || !$owner || ($owner != $vmid); $volids->{$volid} = 1; -- 2.47.3