From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id B22DE1FF138 for ; Mon, 29 Jun 2026 16:06:17 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7890921570; Mon, 29 Jun 2026 16:05:19 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH container v9 05/10] allow pending mount point changes if storage is gone Date: Mon, 29 Jun 2026 16:04:34 +0200 Message-ID: <20260629140439.184878-6-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260629140439.184878-1-m.koeppl@proxmox.com> References: <20260629140439.184878-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782741871529 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UTVSCC2T4FCESCORNZKHAVNCTRFOWPP3 X-Message-ID-Hash: UTVSCC2T4FCESCORNZKHAVNCTRFOWPP3 X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Previously, applying a pending removal of an unused volume whose backing storage was already removed would fail with "unable to apply pending change unusedN", leaving a dangling reference that could never be cleaned up. Guard the volume deletion in vmconfig_apply_pending and vmconfig_hotplug_pending with a check to ensure that the storage exists. If the storage is gone, drop the entry with a warning instead of trying to free a volume that no longer exists. Apply the same check when a detached mount point is turned into an 'unusedN' entry, so a volume on a removed storage is not re-added as a dangling unused entry, matching VM behavior. Signed-off-by: Michael Köppl --- src/PVE/LXC/Config.pm | 43 ++++++++++++++++++++++++++++++++++--------- 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index c8098538..a3dd3a1a 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -1663,8 +1663,14 @@ sub vmconfig_hotplug_pending { # pass } elsif ($opt =~ m/^unused(\d+)$/) { my $volid = $class->parse_volume($opt, $conf->{$opt})->{volume}; - PVE::LXC::delete_mountpoint_volume($storecfg, $vmid, $volid) - if !$class->is_volume_in_use($conf, $volid, 1, 1); + my ($storeid) = PVE::Storage::parse_volume_id($volid); + if (PVE::Storage::storage_config($storecfg, $storeid, 1)) { + PVE::LXC::delete_mountpoint_volume($storecfg, $vmid, $volid) + if !$class->is_volume_in_use($conf, $volid, 1, 1); + } else { + PVE::RESTEnvironment::log_warn( + "storage '$storeid' no longer exists, unused volume '$volid' will be removed"); + } } elsif ($opt eq 'swap') { $hotplug_memory->(undef, 0); } elsif ($opt eq 'cpulimit') { @@ -1765,14 +1771,27 @@ sub vmconfig_apply_pending { if ($opt =~ m/^mp(\d+)$/) { my $mp = $class->parse_volume($opt, $conf->{$opt}); if ($mp->{type} eq 'volume') { - # FIXME: use $mp->{volume} for is_volume_in_use, fix conditions for check - $class->add_unused_volume($conf, $mp->{volume}) - if !$class->is_volume_in_use($conf, $conf->{$opt}, 1, 1); + my ($storeid, undef) = PVE::Storage::parse_volume_id($mp->{volume}); + if (PVE::Storage::storage_config($storecfg, $storeid, 1)) { + # FIXME: use $mp->{volume} for is_volume_in_use, fix conditions for check + $class->add_unused_volume($conf, $mp->{volume}) + if !$class->is_volume_in_use($conf, $conf->{$opt}, 1, 1); + } else { + PVE::RESTEnvironment::log_warn( + "storage '$storeid' no longer exists, volume '$mp->{volume}' will be removed" + ); + } } } elsif ($opt =~ m/^unused(\d+)$/) { my $volid = $class->parse_volume($opt, $conf->{$opt})->{volume}; - PVE::LXC::delete_mountpoint_volume($storecfg, $vmid, $volid) - if !$class->is_volume_in_use($conf, $volid, 1, 1); + my ($storeid) = PVE::Storage::parse_volume_id($volid); + if (PVE::Storage::storage_config($storecfg, $storeid, 1)) { + PVE::LXC::delete_mountpoint_volume($storecfg, $vmid, $volid) + if !$class->is_volume_in_use($conf, $volid, 1, 1); + } else { + PVE::RESTEnvironment::log_warn( + "storage '$storeid' no longer exists, unused volume '$volid' will be removed"); + } } elsif ($opt =~ m/^net(\d+)$/) { if ($have_sdn) { my $net = $class->parse_lxc_network($conf->{$opt}); @@ -1891,8 +1910,14 @@ sub apply_pending_mountpoint { if (defined($old)) { my $mp = $class->parse_volume($opt, $old); if ($mp->{type} eq 'volume') { - $class->add_unused_volume($conf, $mp->{volume}) - if !$class->is_volume_in_use($conf, $conf->{$opt}, 1, 1); + my ($storeid) = PVE::Storage::parse_volume_id($mp->{volume}); + if (PVE::Storage::storage_config($storecfg, $storeid, 1)) { + $class->add_unused_volume($conf, $mp->{volume}) + if !$class->is_volume_in_use($conf, $conf->{$opt}, 1, 1); + } else { + PVE::RESTEnvironment::log_warn( + "storage '$storeid' no longer exists, volume '$mp->{volume}' will be removed"); + } } } } -- 2.47.3