From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 46E1F1FF138 for ; Mon, 29 Jun 2026 16:05:36 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id AD485214AE; Mon, 29 Jun 2026 16:05:17 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH storage v9 01/10] fix #3711: vdisk_free: print warning if storage does not exist Date: Mon, 29 Jun 2026 16:04:30 +0200 Message-ID: <20260629140439.184878-2-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260629140439.184878-1-m.koeppl@proxmox.com> References: <20260629140439.184878-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782741871238 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: V75V4LDDAVCQ36AV2MOMUTUYTBNW7EW2 X-Message-ID-Hash: V75V4LDDAVCQ36AV2MOMUTUYTBNW7EW2 X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Removing a guest or one of its volumes should not fail when the volume's backing storage does not exist in the configuration. Instead of dying, warn and return so the removal can proceed. From PVE's point of view, the volume is gone anyway. Pass the noerr flag to storage_config() so this case is actually reached. Signed-off-by: Michael Köppl --- src/PVE/Storage.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index 64ea9dad..55462ff6 100755 --- a/src/PVE/Storage.pm +++ b/src/PVE/Storage.pm @@ -1187,7 +1187,12 @@ sub vdisk_free { my ($cfg, $volid) = @_; my ($storeid, $volname) = parse_volume_id($volid); - my $scfg = storage_config($cfg, $storeid); + my $scfg = storage_config($cfg, $storeid, 1); + if (!$scfg) { + log_warn("storage '$storeid' does not exist, volume '$volid' could not be freed"); + return; + } + my $plugin = PVE::Storage::Plugin->lookup($scfg->{type}); activate_storage($cfg, $storeid); -- 2.47.3