From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C183F1FF138 for ; Mon, 29 Jun 2026 16:06:09 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3140B21544; Mon, 29 Jun 2026 16:05:19 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v9 10/10] display warnings for storage errors or if storage no longer exists Date: Mon, 29 Jun 2026 16:04:39 +0200 Message-ID: <20260629140439.184878-11-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260629140439.184878-1-m.koeppl@proxmox.com> References: <20260629140439.184878-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782741871915 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4D3BQLIKMF3DKUKVJUAO6F22WH5YMEFW X-Message-ID-Hash: 4D3BQLIKMF3DKUKVJUAO6F22WH5YMEFW X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Instead of continuing without informing the user, a warning will now be displayed if the owner of a volume could not be determined due to a storage error. In addition, an explicit check for the existence of the underlying storage is added before the ownership check. If the storage no longer exists, a warning will be displayed, consistent with the handling of this scenario in other functions. Signed-off-by: Michael Köppl --- src/PVE/QemuServer.pm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 31680483..5cb31bdb 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -1557,6 +1557,7 @@ sub vm_is_volid_owner { if ($volid !~ m|^/|) { my ($path, $owner); eval { ($path, $owner) = PVE::Storage::path($storecfg, $volid); }; + log_warn("ownership of volume '$volid' could not be determined: $@") if $@; if ($owner && ($owner == $vmid)) { return 1; } @@ -1574,8 +1575,13 @@ sub vmconfig_register_unused_drive { delete $conf->{'special-sections'}->{cloudinit}; } elsif (!drive_is_cdrom($drive)) { my $volid = $drive->{file}; - if (vm_is_volid_owner($storecfg, $vmid, $volid)) { - PVE::QemuConfig->add_unused_volume($conf, $volid, $vmid); + my ($storeid, undef) = PVE::Storage::parse_volume_id($volid); + if (PVE::Storage::storage_config($storecfg, $storeid, 1)) { + if (vm_is_volid_owner($storecfg, $vmid, $volid)) { + PVE::QemuConfig->add_unused_volume($conf, $volid, $vmid); + } + } else { + log_warn("storage '$storeid' no longer exists, volume '$volid' will be removed"); } } } -- 2.47.3