From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 266331FF146 for ; Tue, 23 Jun 2026 16:36:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4651949FC; Tue, 23 Jun 2026 16:35:14 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-widget-toolkit 08/13] form: introduce new 'proxmoxtextarea' field Date: Tue, 23 Jun 2026 16:33:25 +0200 Message-ID: <20260623143402.772452-9-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260623143402.772452-1-m.carrara@proxmox.com> References: <20260623143402.772452-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782225247894 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FUEHKS2B2LWZTOLVE2J43SUN3IOL7FFZ X-Message-ID-Hash: FUEHKS2B2LWZTOLVE2J43SUN3IOL7FFZ X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Define a new field named `proxmoxtextarea` and let it extend the `TextArea` field that Ext JS ships. `proxmoxtextarea` uses the exact same logic as `proxmoxtextfield`. This means that it also supports the `skipEmptyText` attribute, which is used to omit sending an empty string to the backend if the field is left empty. Signed-off-by: Max R. Carrara --- src/form/TextAreaField.js | 47 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/src/form/TextAreaField.js b/src/form/TextAreaField.js index f4b0bb4..ae2e922 100644 --- a/src/form/TextAreaField.js +++ b/src/form/TextAreaField.js @@ -59,3 +59,50 @@ Ext.define('Proxmox.form.field.Base64TextArea', { this.validate(); }, }); + +Ext.define('Proxmox.form.field.TextArea', { + extend: 'Ext.form.field.TextArea', + alias: ['widget.proxmoxtextarea'], + + config: { + skipEmptyText: true, + deleteEmpty: false, + trimValue: false, + }, + + getSubmitData: function () { + let me = this, + data = null, + val; + if (!me.disabled && me.submitValue && !me.isFileUpload()) { + val = me.getSubmitValue(); + if (val !== null) { + data = {}; + data[me.getName()] = val; + } else if (me.getDeleteEmpty()) { + data = {}; + data.delete = me.getName(); + } + } + return data; + }, + + getSubmitValue: function () { + let me = this; + + let value = this.processRawValue(this.getRawValue()); + if (me.getTrimValue() && typeof value === 'string') { + value = value.trim(); + } + if (value !== '') { + return value; + } + + return me.getSkipEmptyText() ? null : value; + }, + + setAllowBlank: function (allowBlank) { + this.allowBlank = allowBlank; + this.validate(); + }, +}); -- 2.47.3