From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7769D1FF146 for ; Tue, 23 Jun 2026 16:36:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 459EE4CC7; Tue, 23 Jun 2026 16:35:16 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 12/13] ui: storage view: display error when no editor for storage type exists Date: Tue, 23 Jun 2026 16:33:29 +0200 Message-ID: <20260623143402.772452-13-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260623143402.772452-1-m.carrara@proxmox.com> References: <20260623143402.772452-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782225256323 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: K26YCQ7F3FBWRAIDH67WEXIB7EQ62ART X-Message-ID-Hash: K26YCQ7F3FBWRAIDH67WEXIB7EQ62ART X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ... instead of `throw`ing an exception which gets swallowed by ExtJS and never displayed to the user. Signed-off-by: Max R. Carrara --- www/manager6/dc/StorageView.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/dc/StorageView.js b/www/manager6/dc/StorageView.js index e4c6f07d..bcc02ed5 100644 --- a/www/manager6/dc/StorageView.js +++ b/www/manager6/dc/StorageView.js @@ -13,7 +13,8 @@ Ext.define( createStorageEditWindow: function (type, sid) { let schema = PVE.Utils.storageSchema[type]; if (!schema || !schema.ipanel) { - throw 'no editor registered for storage type: ' + type; + Ext.Msg.alert(gettext('Error'), `No editor registered for storage type '${type}'`); + return; } Ext.create('PVE.storage.BaseEdit', { -- 2.47.3