From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E731F1FF13F for ; Thu, 18 Jun 2026 12:54:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9CC261409A; Thu, 18 Jun 2026 12:55:01 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Subject: [PATCH installer] ui: gtk3: set up proper RGBA visual for main window Date: Thu, 18 Jun 2026 12:54:20 +0200 Message-ID: <20260618105423.664293-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781780008146 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OBYLZ4LTQ6UYPX5N6IKJ5GMRLVF3BPYD X-Message-ID-Hash: OBYLZ4LTQ6UYPX5N6IKJ5GMRLVF3BPYD X-MailFrom: c.heiss@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This properly fixes all instances of broken damage-tracking with dialogs and other overlaying widgets on top of the WebKit2 view. By using RGBA instead of a the default RGB visual, the GTK <-> X server interaction for compositing widgets on top of each other seem to work correctly. This was previously worked around in one instance and thus also effectively reverts commit 55c764163 ("gui: redraw window after closing disk setup dialog") .. as it is now no longer needed. Signed-off-by: Christoph Heiss --- proxinstall | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/proxinstall b/proxinstall index 49b1612..51ead26 100755 --- a/proxinstall +++ b/proxinstall @@ -236,6 +236,13 @@ sub create_main_window { Proxmox::UI::init_gtk($gtk_state, $iso_env); + # make it play nice without a compositor, i.e. this enables proper damage + # tracking in GTK in combination with WebKit2 + my $visual = $window->get_screen()->get_rgba_visual(); + if ($visual) { + $window->set_visual($visual); + } + $window->show_all; $window->present(); } @@ -1651,7 +1658,6 @@ sub create_hdoption_view { $dialog->show(); $dialog->run(); - $gtk_state->{window}->queue_draw(); my $get_float = sub { my ($entry) = @_; -- 2.54.0