From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 89FAB1FF14F for ; Wed, 17 Jun 2026 13:53:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CD066326EA; Wed, 17 Jun 2026 13:53:11 +0200 (CEST) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: [PATCH manager 1/1] ui: ceph: config db: auto-show MASK column when masks are in use Date: Wed, 17 Jun 2026 19:52:29 +0800 Message-ID: <20260617115229.3763257-2-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260617115229.3763257-1-k.chai@proxmox.com> References: <20260617115229.3763257-1-k.chai@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781697101570 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.283 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 35HWXDIC33RYBG4ZDZHHA4ZKQFKX6NJC X-Message-ID-Hash: 35HWXDIC33RYBG4ZDZHHA4ZKQFKX6NJC X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: A mask narrows the scope of a config entry to a subset of daemons matching a qualifier such as 'class:hdd' or 'host:node1'. Without it visible, an entry set for 'osd/class:hdd' shows up as 'osd' in the table, indistinguishable from a setting that applies to all OSDs. The MASK column existed since the table was introduced but was hidden in f9bbe5fe to reduce noise: the field is empty for the vast majority of entries on typical clusters. Exposing it unconditionally would add an empty column for users who never set any masked options. Check after the store loads whether any entry has a non-empty mask and unhide the column only then. On clusters without masked settings the table is unaffected. Fixes #6948. Signed-off-by: Kefu Chai --- www/manager6/ceph/Config.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/www/manager6/ceph/Config.js b/www/manager6/ceph/Config.js index fa2e1b71..0d670e0e 100644 --- a/www/manager6/ceph/Config.js +++ b/www/manager6/ceph/Config.js @@ -62,6 +62,13 @@ Ext.define('PVE.node.CephConfigDb', { me.callParent(); + me.getStore().on('load', function(store) { + let hasMask = store.getRange().some(rec => rec.get('mask')); + if (hasMask) { + me.down('[dataIndex=mask]').setVisible(true); + } + }); + Proxmox.Utils.monStoreErrors(me, me.getStore()); me.getStore().load(); }, -- 2.47.3