From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 296281FF14C for ; Fri, 12 Jun 2026 12:09:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0CA0AF0BC; Fri, 12 Jun 2026 12:09:00 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: [PATCH manager] ui: utils: do not display 0% disk usage for vms Date: Fri, 12 Jun 2026 12:08:51 +0200 Message-ID: <20260612100856.243493-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781258886845 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.127 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ATP3NED3EOFTT6CCUEYQ5HG7ULJEKAOG X-Message-ID-Hash: ATP3NED3EOFTT6CCUEYQ5HG7ULJEKAOG X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Getting the disk usage of a VM requires to query the QEMU guest agent (get-fsinfo) and at the moment the {vmid}/status/current does not talk to the agent so reporting this information would require a non-trivial changes. Before the eslint fixes, the UI was not displaying disk usage so we revet back to that rather than always reporting 0%. Fixes: 4d739f4a (ui: utils: eslint fixes and code cleanup/refactoring) Signed-off-by: Maximiliano Sandoval --- Notes: - quickly tested on a pve 9.2 vm - checked that make tidy does not change this back - Appeared in ticket #7270568 www/manager6/Utils.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index bbf59d8f4..040b5ae01 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1272,7 +1272,8 @@ Ext.define('PVE.Utils', { calculate_disk_usage: function (data) { if ( !Ext.isNumeric(data.disk) || - ((data.type === 'qemu' || data.type === 'lxc') && data.uptime === 0) || + data.type === 'qemu' || + (data.type === 'lxc' && data.uptime === 0) || data.maxdisk === 0 ) { return -1; @@ -1297,7 +1298,8 @@ Ext.define('PVE.Utils', { if ( !Ext.isNumeric(disk) || maxdisk === 0 || - ((type === 'qemu' || type === 'lxc') && record.data.uptime === 0) + type === 'qemu' || + (type === 'lxc' && record.data.uptime === 0) ) { return ''; } -- 2.47.3