From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1D72A1FF13C for ; Thu, 11 Jun 2026 16:59:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 025D1F63E; Thu, 11 Jun 2026 16:59:51 +0200 (CEST) From: David Riley To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 1/9] ui: replace var with let to match style guide for variable declaration Date: Thu, 11 Jun 2026 16:59:27 +0200 Message-ID: <20260611145935.147788-2-d.riley@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260611145935.147788-1-d.riley@proxmox.com> References: <20260611145935.147788-1-d.riley@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781189937015 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.197 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IP2B433JUC4JNIITFQ73C7HTQAJ6V6QO X-Message-ID-Hash: IP2B433JUC4JNIITFQ73C7HTQAJ6V6QO X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: No semantic change intended. Link: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Variables Signed-off-by: David Riley --- www/manager6/grid/PoolMembers.js | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js index b0c9ccb3..69f50e30 100644 --- a/www/manager6/grid/PoolMembers.js +++ b/www/manager6/grid/PoolMembers.js @@ -13,7 +13,7 @@ Ext.define('PVE.pool.AddVM', { }, initComponent: function () { - var me = this; + let me = this; if (!me.pool) { throw 'no pool specified'; @@ -23,7 +23,7 @@ Ext.define('PVE.pool.AddVM', { me.method = 'PUT'; me.extraRequestParams.poolid = me.pool; - var vmsField = Ext.create('Ext.form.field.Text', { + let vmsField = Ext.create('Ext.form.field.Text', { name: 'vms', hidden: true, allowBlank: false, @@ -32,7 +32,7 @@ Ext.define('PVE.pool.AddVM', { let basicFilter = (data) => (data.type === 'lxc' || data.type === 'qemu') && data.pool !== me.pool; - var vmStore = Ext.create('Ext.data.Store', { + let vmStore = Ext.create('Ext.data.Store', { model: 'PVEResources', sorters: [ { @@ -43,7 +43,7 @@ Ext.define('PVE.pool.AddVM', { filters: [(item) => basicFilter(item.data)], }); - var vmGrid = Ext.create('widget.grid', { + let vmGrid = Ext.create('widget.grid', { store: vmStore, border: true, height: 480, @@ -53,7 +53,7 @@ Ext.define('PVE.pool.AddVM', { mode: 'SIMPLE', listeners: { selectionchange: function (model, selected, opts) { - var selectedVms = []; + let selectedVms = []; selected.forEach(function (vm) { selectedVms.push(vm.data.vmid); }); @@ -127,7 +127,7 @@ Ext.define('PVE.pool.AddStorage', { extend: 'Proxmox.window.Edit', initComponent: function () { - var me = this; + let me = this; if (!me.pool) { throw 'no pool specified'; @@ -166,7 +166,7 @@ Ext.define('PVE.grid.PoolMembers', { stateId: 'grid-pool-members', initComponent: function () { - var me = this; + let me = this; if (!me.pool) { throw 'no pool specified'; @@ -193,7 +193,7 @@ Ext.define('PVE.grid.PoolMembers', { ], }); - var coldef = PVE.data.ResourceStore.defaultColumns().filter( + let coldef = PVE.data.ResourceStore.defaultColumns().filter( (c) => c.dataIndex !== 'tags' && c.dataIndex !== 'lock', ); @@ -201,9 +201,9 @@ Ext.define('PVE.grid.PoolMembers', { me.rstore.load(); }; - var sm = Ext.create('Ext.selection.RowModel', {}); + let sm = Ext.create('Ext.selection.RowModel', {}); - var remove_btn = new Proxmox.button.Button({ + let remove_btn = new Proxmox.button.Button({ text: gettext('Remove'), disabled: true, selModel: sm, @@ -214,7 +214,7 @@ Ext.define('PVE.grid.PoolMembers', { ); }, handler: function (btn, event, rec) { - var params = { delete: 1, poolid: me.pool }; + let params = { delete: 1, poolid: me.pool }; if (rec.data.type === 'storage') { params.storage = rec.data.storage; } else if ( @@ -254,7 +254,7 @@ Ext.define('PVE.grid.PoolMembers', { text: gettext('Virtual Machine'), iconCls: 'fa fa-desktop', handler: function () { - var win = Ext.create('PVE.pool.AddVM', { pool: me.pool }); + let win = Ext.create('PVE.pool.AddVM', { pool: me.pool }); win.on('destroy', reload); win.show(); }, @@ -263,7 +263,7 @@ Ext.define('PVE.grid.PoolMembers', { text: gettext('Storage'), iconCls: 'fa fa-hdd-o', handler: function () { - var win = Ext.create('PVE.pool.AddStorage', { pool: me.pool }); + let win = Ext.create('PVE.pool.AddStorage', { pool: me.pool }); win.on('destroy', reload); win.show(); }, @@ -280,7 +280,7 @@ Ext.define('PVE.grid.PoolMembers', { listeners: { itemcontextmenu: PVE.Utils.createCmdMenu, itemdblclick: function (v, record) { - var ws = me.up('pveStdWorkspace'); + let ws = me.up('pveStdWorkspace'); ws.selectById(record.data.id); }, activate: reload, -- 2.47.3