From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 289631FF13C for ; Thu, 11 Jun 2026 16:25:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F2225DD40; Thu, 11 Jun 2026 16:25:00 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server] api: create: check VM.PowerMgmt on the pool too Date: Thu, 11 Jun 2026 16:24:25 +0200 Message-ID: <20260611142427.495288-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781187819137 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.127 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HK4T4VZAGFNGDWUWFZQBQQ7YRQX4FEB3 X-Message-ID-Hash: HK4T4VZAGFNGDWUWFZQBQQ7YRQX4FEB3 X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: If a VM is part of a resource pool, it is possible to start it with the permission either in /pool or in /vm. The upfront check done when creating a VM with --start=1 is extended accordingly to look for the permission on the resource pool if appropriate. Fixes: 5086f472 ("api: create: check VM.PowerMgmt up front when starting after create") Signed-off-by: Maximiliano Sandoval --- src/PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index 54883f1e..4dd546ae 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -1272,7 +1272,7 @@ __PACKAGE__->register_method({ # vm_start is invoked directly from the create/restore worker, so its # own permissions predicate doesn't fire here - check VM.PowerMgmt up # front whenever the caller asked us to start the VM after creation. - $rpcenv->check($authuser, "/vms/$vmid", ['VM.PowerMgmt']) + $rpcenv->check_vm_perm($authuser, $vmid, $pool, ['VM.PowerMgmt']) if $start_after_create; if ($rpcenv->check($authuser, "/vms/$vmid", ['VM.Allocate'], 1)) { -- 2.47.3