From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F09181FF146 for ; Tue, 09 Jun 2026 16:29:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6C81E1583B; Tue, 9 Jun 2026 16:29:06 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 4/4] block job: mirror: use correct unit for logging bandwidth limit Date: Tue, 9 Jun 2026 16:28:49 +0200 Message-ID: <20260609142858.1063820-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260609142858.1063820-1-f.ebner@proxmox.com> References: <20260609142858.1063820-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781015296262 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: N3DBIXNILGUNFJ3AUZLACNHYZT2AYCJM X-Message-ID-Hash: N3DBIXNILGUNFJ3AUZLACNHYZT2AYCJM X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The $bwlimit option is multipled by 1024, so it's KiB, not KB. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/BlockJob.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/QemuServer/BlockJob.pm b/src/PVE/QemuServer/BlockJob.pm index c8b0b030..921f046c 100644 --- a/src/PVE/QemuServer/BlockJob.pm +++ b/src/PVE/QemuServer/BlockJob.pm @@ -261,7 +261,7 @@ my sub common_mirror_qmp_options { if (defined($bwlimit)) { $opts->{speed} = $bwlimit * 1024; - print "drive mirror is starting for $device_id with bandwidth limit: ${bwlimit} KB/s\n"; + print "drive mirror is starting for $device_id with bandwidth limit: ${bwlimit} KiB/s\n"; } else { print "drive mirror is starting for $device_id\n"; } -- 2.47.3