From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1FDF81FF13B for ; Wed, 03 Jun 2026 17:58:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 36C1C1304D; Wed, 3 Jun 2026 17:58:26 +0200 (CEST) From: Nicolas Frey To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox 0/2] fix #7541: zfs status: account for msg directly after status in vdev parser Date: Wed, 3 Jun 2026 17:58:20 +0200 Message-ID: <20260603155822.370223-1-n.frey@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.135 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: AMYDCVFGHHLVIJ3RX3SMIH4JYJ4WIRTJ X-Message-ID-Hash: AMYDCVFGHHLVIJ3RX3SMIH4JYJ4WIRTJ X-MailFrom: nfrey@miso.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: As reported in Enterprise Support, when a spare is "INUSE", it has a `msg` right after the STATUS, which the parser previously did not account for. This patch-series was previously for PBS, but as proxmox-disks is factoring that code out, it makes sense to make the change here. I reckon as PBS will at some point use proxmox-disks, it's fine to only fix this parser issue here; though please let me know if this fix should also be seperately done again for PBS. It also doesn't quite 'fix' the bug mentioned in the second patch, as PBS doesn't use proxmox-disks yet. Changes since PBS version: * simplify parsing logic by optionally parsing out the stats resulting in a single return and msg parse. This way there is no "special case" proxmox: Nicolas Frey (2): disks: zpool: add `VDevStats` struct instead of 3 optional u64s fix #7541: zfs status: account for msg directly after status in vdev parser proxmox-disks/src/zpool_status.rs | 53 ++++++++++++------------------- 1 file changed, 21 insertions(+), 32 deletions(-) Summary over all repositories: 1 files changed, 21 insertions(+), 32 deletions(-) -- Generated by murpp 0.12.0