From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1D0F21FF13B for ; Wed, 03 Jun 2026 07:51:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EA54135FCC; Wed, 3 Jun 2026 07:51:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780465848; x=1781070648; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KrBSxO4FbOx1ZSG5+COFkfB/HPb3y717XxwzoV/5aLE=; b=Z1Lb3dI85/B2nNuO+P+tGpY41TuguIsTS96vKNjOqi8us9IXBivu3YEvQN5A4npM2B sC5jZYMPykRmLiZcgy7I9odYdbKAfvaiO3ZT41rzJZIfPlEBLQv2MvQD2t3VONVFzP+R bR/fIss8MPZ8LRl8FuBtnKzitf444FLLFhMcbDwooiuiLB6w4qW4DADMyWod++SvhqSD r9WFfk7Q+ZL4H3p9aaoHELSDudv0YC1rKplQhJlw7E0O2hluaYKGl92xfDpZCxpOJiD2 at5hU9tfi+LKmejihq7nWMz/cyrIx6qCsk2FwZLPp4f9OJEWFB9zA969iFU8OpyU6NPc Rh0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780465848; x=1781070648; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KrBSxO4FbOx1ZSG5+COFkfB/HPb3y717XxwzoV/5aLE=; b=JIM+VH1/Aiul3ZLmFIP1QrW9lBhWYLctKeIPvJJa8QIdp+tO31rzPpwPlUuIzPYeve v/OCM67rzGQfn98c/rcx+q8qGxSBFFm0N26yCky5yt2iMLqJ1Yhqcha45/JFrkfaO0A4 FuefBDIrhHEiEHL6r/ANE6+rusOM1q218Road8R34XLmeUIB7vZ6FC6150pm0YnD/BEv hge5m5ApvGlP2UkHzMZ0jRxPX5mqfDGCBwDFkW5TZD15pPyEOkF5yiKdXGijgv3J/5GE QEFzS85BjHLr5l5hJoU2sHF7MCZ8tPKClwp1sYdpwp8PdaG1Nkvf3yLXmkHIiKjcBV/h w3NA== X-Gm-Message-State: AOJu0YwC52p8bNYiJQV5L7+CPMRykUcbUh8wjTVMKEQhEZXhu5wMsALJ ohWR0VqYG4Mz1CNMzmyf/h36tV/mpJXVogtxcrdTlW19F6U7l/fmyem1QU6wwtnPoX4= X-Gm-Gg: Acq92OGQtCAH1YAQrn3T6NA1HlznJYlRTZgHJ3M78mf87E3JGh4CTOurthsodWuayhC +zHk2qnhy+qX70zzJK271Ln4p7Baqss0YNlegGhyhzvFJiVS3pL2N2lDXWhCHQTvCH3h8dsjfXV RBZYgVhOVWVTRDRiqvcZTUv6lojnZyHniEvkPRUILvtbj38AIT+eqaPNOayRk11tQwlwdBIFt1z QVjKaiyKnxj9yOlS032f4fDDtFX4oEDaQZjcKyqE+CiMsjy3rQ6fqMrgIUBhS+xUEY9Vzi51jzK vDKcG0I4Pa/KeXWrJGWlFy0Fvlj7K9YSPMHAzO7HKFzceLzMq57Shd3FxE+dek+BFmbKF1KNRkj yYvIAsSN7IVYgWDzJ0QZ5upnhtNJ8HmHUw2EeSXJKrjs+TdsUo+LvMbAMfumQU2BW88TOhf9EWb QYC/AF5u9IfSO0p7uQtGE+hG3CyuJkiZeV4WHXzoo/0FSGKfdtgUqjFsUlsoQ= X-Received: by 2002:a17:902:c948:b0:2b2:4d36:7aa with SMTP id d9443c01a7336-2c1644cab59mr20672075ad.35.1780465848024; Tue, 02 Jun 2026 22:50:48 -0700 (PDT) From: Kaiyang Wu X-Google-Original-From: Kaiyang Wu To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server] query-machine-capabilities: check vendor string length for strncmp Date: Wed, 3 Jun 2026 13:50:05 +0800 Message-ID: <20260603055031.106241-1-wukaiyang@loongfans.cn> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.256 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 1 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UYOYSVIUXQSI6HSTI7NRUBRPIHEEGR3E X-Message-ID-Hash: UYOYSVIUXQSI6HSTI7NRUBRPIHEEGR3E X-MailFrom: wukaiyang2003@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fix build error on unknown vendors ('fallback'): error: ‘strncmp’ of strings of length 7 and 12 and bound of 12 evaluates to nonzero [-Werror=string-compare] Signed-off-by: Kaiyang Wu --- src/query-machine-capabilities/query-machine-capabilities.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/query-machine-capabilities/query-machine-capabilities.c b/src/query-machine-capabilities/query-machine-capabilities.c index abb47acd..25d06db7 100644 --- a/src/query-machine-capabilities/query-machine-capabilities.c +++ b/src/query-machine-capabilities/query-machine-capabilities.c @@ -204,7 +204,7 @@ int main() { eprintf("Error writing to file '" OUTPUT_PATH "': %s\n", strerror(errno)); } - if (strncmp(vendor, "AuthenticAMD", 12) == 0) { + if (strncmp(vendor, "AuthenticAMD", strnlen(vendor, 12)) == 0) { cpu_caps_amd_sev_t caps_sev; query_cpu_capabilities_sev(&caps_sev); @@ -222,7 +222,7 @@ int main() { caps_sev.sev_es_support ? "true" : "false", caps_sev.sev_snp_support ? "true" : "false" ); - } else if (strncmp(vendor, "GenuineIntel", 12) == 0) { + } else if (strncmp(vendor, "GenuineIntel", strnlen(vendor, 12)) == 0) { cpu_caps_intel_tdx_t caps_tdx; if (query_cpu_capabilities_tdx(&caps_tdx) == 0) { ret = fprintf(file, -- 2.52.0