From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8E7E41FF141 for ; Tue, 02 Jun 2026 12:02:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 434CCDAEE; Tue, 2 Jun 2026 12:02:36 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH manager v2 04/12] ui: ha: node affinity: handle non-existent nodes Date: Tue, 2 Jun 2026 12:01:08 +0200 Message-ID: <20260602100226.180071-5-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260602100226.180071-1-d.kral@proxmox.com> References: <20260602100226.180071-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780394515409 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: E6BWOIJT7DIK7QQXH5OXGJFH3CXUZQPO X-Message-ID-Hash: E6BWOIJT7DIK7QQXH5OXGJFH3CXUZQPO X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Though unlikely, the node in a HA node affinity rule could not exist in the store anymore. Therefore handle non-existent nodes by adding them to the store. Signed-off-by: Daniel Kral --- changes since v1: - new www/manager6/ha/rules/NodeAffinityRuleEdit.js | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/www/manager6/ha/rules/NodeAffinityRuleEdit.js b/www/manager6/ha/rules/NodeAffinityRuleEdit.js index 4574d9ef..1223efc8 100644 --- a/www/manager6/ha/rules/NodeAffinityRuleEdit.js +++ b/www/manager6/ha/rules/NodeAffinityRuleEdit.js @@ -99,13 +99,17 @@ Ext.define('PVE.ha.rules.NodeAffinityInputPanel', { string.split(',').forEach(function (e, idx, array) { let [node, priority] = e.split(':'); - store.each(function (record) { - if (record.get('node') === node) { - sm.select(record, true); - record.set('priority', priority); - record.commit(); - } - }); + + let record = store.findRecord('node', node, 0, false, true, true); + if (record) { + record.set('priority', priority); + record.commit(); + } else { + let addedRecords = store.add({ node, priority }); + record = addedRecords[0]; + } + + sm.select(record, true); }); nodegrid.reconfigure(store); }; -- 2.47.3