From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AA44D1FF138 for ; Mon, 01 Jun 2026 16:56:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AF2C7318B3; Mon, 1 Jun 2026 16:56:32 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 2/2] migration: local volume: activate for querying the size (required for qcow2 on LVM) Date: Mon, 1 Jun 2026 16:55:02 +0200 Message-ID: <20260601145528.285536-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260601145528.285536-1-f.ebner@proxmox.com> References: <20260601145528.285536-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780325721202 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record T_SPF_PERMERROR 0.01 SPF: test of record failed (permerror) Message-ID-Hash: KZTBMRY7IWQYJZTL6VRDQOIH67OJC2UJ X-Message-ID-Hash: KZTBMRY7IWQYJZTL6VRDQOIH67OJC2UJ X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For qcow2 on LVM, it is necessary that the volumes are active to be able to query the size. For offline migration, the volumes would be activated later in storage_migrate() and for online migration, the volumes are already active. This makes an attempt to offline migrate a qcow2 on LVM volume correctly fail with an error about lacking support, rather than an error about not being to determine the size. See also commit "migration: abort early when size or format cannot be determined" for context. Signed-off-by: Fiona Ebner --- src/PVE/QemuMigrate.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm index 6b563343..8da6f15d 100644 --- a/src/PVE/QemuMigrate.pm +++ b/src/PVE/QemuMigrate.pm @@ -449,6 +449,8 @@ sub scan_local_volumes { $local_volumes->{$volid}->{bwlimit} = $self->get_bwlimit($sid, $targetsid); $local_volumes->{$volid}->{targetsid} = $targetsid; + # For some volumes, like qcow2 on LVM, it is necessary to activate to query the size. + PVE::Storage::activate_volumes($storecfg, [$volid]); $local_volumes->{$volid}->@{qw(size format)} = PVE::Storage::volume_size_info($storecfg, $volid); die "unable to determine size for volume '$volid'\n" -- 2.47.3