From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 68D031FF138 for ; Mon, 01 Jun 2026 16:56:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A81F731782; Mon, 1 Jun 2026 16:56:31 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 1/2] migration: local volume: abort early when size or format cannot be determined Date: Mon, 1 Jun 2026 16:55:01 +0200 Message-ID: <20260601145528.285536-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260601145528.285536-1-f.ebner@proxmox.com> References: <20260601145528.285536-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780325721146 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record T_SPF_PERMERROR 0.01 SPF: test of record failed (permerror) Message-ID-Hash: FQ3RZL2XYMGO7SFG6QU7ZQMGJFTIJAIL X-Message-ID-Hash: FQ3RZL2XYMGO7SFG6QU7ZQMGJFTIJAIL X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Part of the issue in bug #7554 is that an offline volume migration will continue even if the size and format cannot be determined. Not having the format would lead to the 'with-snapshots' parameter not being set, despite the format being qcow2 and so the migration would wrongly continue with raw+size as the stream format. If 'with-snapshots' were set, the plugin would correctly report that there is no possible transfer format (the same restriction is present in file-based storages with snapshot-as-volume-chain currently). Signed-off-by: Fiona Ebner --- src/PVE/QemuMigrate.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm index d4de9f87..6b563343 100644 --- a/src/PVE/QemuMigrate.pm +++ b/src/PVE/QemuMigrate.pm @@ -451,6 +451,10 @@ sub scan_local_volumes { $local_volumes->{$volid}->@{qw(size format)} = PVE::Storage::volume_size_info($storecfg, $volid); + die "unable to determine size for volume '$volid'\n" + if !defined($local_volumes->{$volid}->{size}); + die "unable to determine format for volume '$volid'\n" + if !defined($local_volumes->{$volid}->{format}); $local_volumes->{$volid}->{is_vmstate} = $attr->{is_vmstate} ? 1 : 0; $local_volumes->{$volid}->{is_cloudinit} = $attr->{is_cloudinit} ? 1 : 0; -- 2.47.3