From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EBFF51FF138 for ; Mon, 01 Jun 2026 16:56:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3EDC031637; Mon, 1 Jun 2026 16:56:30 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH-SERIES qemu-server 0/2] partially fix #7554: avoid incorrectly offline migrating qcow2 on LVM as raw Date: Mon, 1 Jun 2026 16:55:00 +0200 Message-ID: <20260601145528.285536-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780325721090 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record T_SPF_PERMERROR 0.01 SPF: test of record failed (permerror) Message-ID-Hash: C45RBOUOWHEM6MBI35QNPC7ESKXZ2YR5 X-Message-ID-Hash: C45RBOUOWHEM6MBI35QNPC7ESKXZ2YR5 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Because volumes were not activated early for offline migration, getting the size and as a consequence the format would not work for qcow2 on LVM. But migration also continued and not having the format would lead to the 'with-snapshots' parameter not being set, despite the format being qcow2 and so the migration would wrongly continue with raw+size as the stream format. If 'with-snapshots' were set, the plugin would correctly report that there is no possible transfer format (the same restriction is present in file-based storages with snapshot-as-volume-chain). Fix the issue by activating the volumes early, as well as failing when the size and format cannot be determined as an additional guardrail. What could still be implemented is migrating as qcow2+size when there actually are no snapshots. qemu-server: Fiona Ebner (2): migration: local volume: abort early when size or format cannot be determined migration: local volume: activate for querying the size (required for qcow2 on LVM) src/PVE/QemuMigrate.pm | 6 ++++++ 1 file changed, 6 insertions(+) Summary over all repositories: 1 files changed, 6 insertions(+), 0 deletions(-) -- Generated by git-murpp 0.5.0