From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 437071FF13C for ; Thu, 28 May 2026 13:36:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 62A1114BDD; Thu, 28 May 2026 13:36:17 +0200 (CEST) From: Jakob Klocker To: pve-devel@lists.proxmox.com Subject: [PATCH manager 2/3] fix #7513: api: certs: change ACL on certificates path Date: Thu, 28 May 2026 13:35:03 +0200 Message-ID: <20260528113505.12961-3-j.klocker@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260528113505.12961-1-j.klocker@proxmox.com> References: <20260528113505.12961-1-j.klocker@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: L47DN247UGAVNDUVTRVWJPHRB7JPUENE X-Message-ID-Hash: L47DN247UGAVNDUVTRVWJPHRB7JPUENE X-MailFrom: root@dev.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jakob Klocker X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Endpoints under /nodes/{node}/certificates/* required /nodes/{node} permission. To allow least-privileged for certification changes, check the permissions on /nodes/{node}/certificates path instead. Link: https://bugzilla.proxmox.com/show_bug.cgi?id=7513 Signed-off-by: Jakob Klocker --- PVE/API2/ACME.pm | 6 +++--- PVE/API2/Certificates.pm | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/PVE/API2/ACME.pm b/PVE/API2/ACME.pm index a948a72a..3f6679a0 100644 --- a/PVE/API2/ACME.pm +++ b/PVE/API2/ACME.pm @@ -160,7 +160,7 @@ __PACKAGE__->register_method({ path => 'certificate', method => 'POST', permissions => { - check => ['perm', '/nodes/{node}', ['Sys.Modify']], + check => ['perm', '/nodes/{node}/certificates', ['Sys.Modify']], }, description => "Order a new certificate from ACME-compatible CA.", protected => 1, @@ -232,7 +232,7 @@ __PACKAGE__->register_method({ path => 'certificate', method => 'PUT', permissions => { - check => ['perm', '/nodes/{node}', ['Sys.Modify']], + check => ['perm', '/nodes/{node}/certificates', ['Sys.Modify']], }, description => "Renew existing certificate from CA.", protected => 1, @@ -319,7 +319,7 @@ __PACKAGE__->register_method({ path => 'certificate', method => 'DELETE', permissions => { - check => ['perm', '/nodes/{node}', ['Sys.Modify']], + check => ['perm', '/nodes/{node}/certificates', ['Sys.Modify']], }, description => "Revoke existing certificate from CA.", protected => 1, diff --git a/PVE/API2/Certificates.pm b/PVE/API2/Certificates.pm index de8762c5..8da1e93b 100644 --- a/PVE/API2/Certificates.pm +++ b/PVE/API2/Certificates.pm @@ -87,7 +87,7 @@ __PACKAGE__->register_method({ path => 'custom', method => 'POST', permissions => { - check => ['perm', '/nodes/{node}', ['Sys.Modify']], + check => ['perm', '/nodes/{node}/certificates', ['Sys.Modify']], }, description => 'Upload or update custom certificate chain and key.', protected => 1, @@ -165,7 +165,7 @@ __PACKAGE__->register_method({ path => 'custom', method => 'DELETE', permissions => { - check => ['perm', '/nodes/{node}', ['Sys.Modify']], + check => ['perm', '/nodes/{node}/certificates', ['Sys.Modify']], }, description => 'DELETE custom certificate chain and key.', protected => 1, -- 2.47.3