From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A2FCA1FF13A for ; Wed, 27 May 2026 13:01:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CEE34183CB; Wed, 27 May 2026 13:01:14 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 4/6] fix #6424: increase timeout for QMP 'quit' to 60s to avoid issue with bulk suspend Date: Wed, 27 May 2026 13:00:48 +0200 Message-ID: <20260527110106.287916-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260527110106.287916-1-f.ebner@proxmox.com> References: <20260527110106.287916-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779879644144 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qmpclient.pm] Message-ID-Hash: QAGVA5WYP3HRO6ZHD7ALVTUNB3YNKNFE X-Message-ID-Hash: QAGVA5WYP3HRO6ZHD7ALVTUNB3YNKNFE X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The 'quit' QMP command itself is fast, since it only records the shutdown request and notifies the main loop, but getting the response can take a while. The reason is that qmp_dispatch() yields and must be woken after executing the command and at that stage, QEMU is already busy with teardown too. In practice, users can run into the default timeout of 5 seconds when doing bulk suspend. The 'quit' QMP command is only used as part of (potentially) longer-running operations already: - VM hibernation - VM stop - QSD quit: - after enrolling EFI disk certs - terminating instance for TPM Signed-off-by: Fiona Ebner --- src/PVE/QMPClient.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/QMPClient.pm b/src/PVE/QMPClient.pm index 7610121a..a43e661b 100644 --- a/src/PVE/QMPClient.pm +++ b/src/PVE/QMPClient.pm @@ -156,6 +156,12 @@ sub cmd { || $cmd->{execute} eq 'blockdev-snapshot-internal-sync' ) { $timeout = 60 * 60; # 1 hour + } elsif ($cmd->{execute} eq 'quit') { + # The 'quit' QMP command itself is fast, since it only records the shutdown request and + # notifies the main loop, but getting the response can take a while. The reason is that + # qmp_dispatch() yields and must be woken after executing the command and at that stage, + # QEMU is already busy with teardown too. + $timeout = 60; } else { # NOTE: if you came here as user and want to change this, try using IO-Threads first # which move out quite some processing of the main thread, leaving more time for QMP -- 2.47.3