From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8BED21FF13A for ; Wed, 27 May 2026 09:46:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2A663121D7; Wed, 27 May 2026 09:46:21 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 2/2] qmp helpers: use v5.36 and signatures Date: Wed, 27 May 2026 09:44:53 +0200 Message-ID: <20260527074545.41948-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260527074545.41948-1-f.ebner@proxmox.com> References: <20260527074545.41948-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779867922639 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qmphelpers.pm] Message-ID-Hash: CTVPEBQLLC5XCNUONHSYDDJXZO6MYKYT X-Message-ID-Hash: CTVPEBQLLC5XCNUONHSYDDJXZO6MYKYT X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/QMPHelpers.pm | 27 +++++++-------------------- 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/src/PVE/QemuServer/QMPHelpers.pm b/src/PVE/QemuServer/QMPHelpers.pm index 9e0996cc..b4c6d1e7 100644 --- a/src/PVE/QemuServer/QMPHelpers.pm +++ b/src/PVE/QemuServer/QMPHelpers.pm @@ -1,7 +1,6 @@ package PVE::QemuServer::QMPHelpers; -use warnings; -use strict; +use v5.36; use PVE::QemuServer::Helpers; use PVE::QemuServer::Monitor qw(mon_cmd); @@ -15,37 +14,27 @@ our @EXPORT_OK = qw( qemu_objectdel ); -sub nbd_stop { - my ($vmid) = @_; - +sub nbd_stop($vmid) { mon_cmd($vmid, 'nbd-server-stop', timeout => 25); } -sub qemu_deviceadd { - my ($vmid, $devicefull) = @_; - +sub qemu_deviceadd($vmid, $devicefull) { $devicefull = "driver=" . $devicefull; PVE::QemuServer::Monitor::hmp_cmd($vmid, "device_add $devicefull", 25); } -sub qemu_devicedel { - my ($vmid, $deviceid) = @_; - +sub qemu_devicedel($vmid, $deviceid) { PVE::QemuServer::Monitor::hmp_cmd($vmid, "device_del $deviceid", 25); } -sub qemu_objectadd { - my ($vmid, $objectid, $qomtype, %args) = @_; - +sub qemu_objectadd($vmid, $objectid, $qomtype, %args) { mon_cmd($vmid, "object-add", id => $objectid, "qom-type" => $qomtype, %args); return 1; } -sub qemu_objectdel { - my ($vmid, $objectid) = @_; - +sub qemu_objectdel($vmid, $objectid) { mon_cmd($vmid, "object-del", id => $objectid); return 1; @@ -53,9 +42,7 @@ sub qemu_objectdel { # dies if a) VM not running or not existing b) Version query failed # So, any defined return value is valid, any invalid state can be caught by eval -sub runs_at_least_qemu_version { - my ($vmid, $major, $minor, $extra) = @_; - +sub runs_at_least_qemu_version($vmid, $major, $minor, $extra = undef) { my $v = PVE::QemuServer::Monitor::mon_cmd($vmid, 'query-version'); die "could not query currently running version for VM $vmid\n" if !defined($v); $v = $v->{qemu}; -- 2.47.3