From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A6F9E1FF146 for ; Tue, 26 May 2026 09:04:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ADF4A133F1; Tue, 26 May 2026 09:04:44 +0200 (CEST) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network] ui: sdn: wireguard: clarify peer grid and endpoint labels Date: Tue, 26 May 2026 09:04:38 +0200 Message-ID: <20260526070438.18120-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779779055825 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [selectedinterface.name] Message-ID-Hash: OSCKUFYTEGGSGZD6WRJGITJBW5JYB4VD X-Message-ID-Hash: OSCKUFYTEGGSGZD6WRJGITJBW5JYB4VD X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Hannes Laimer --- this should make it more explicit and help if someone is not already familiar with what fields are for, and what setting them means www/manager6/sdn/fabrics/wireguard/InterfacePanel.js | 4 ++++ www/manager6/sdn/fabrics/wireguard/NodeEdit.js | 8 +++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js b/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js index 80fe6919..1bd1c79b 100644 --- a/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js +++ b/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js @@ -372,6 +372,10 @@ Ext.define('PVE.sdn.Fabric.WireGuard.InterfacePanel', { xtype: 'pveSDNWireGuardPeerSelector', reference: 'peerSelector', bind: { + title: Ext.String.format( + gettext('Peers of {0}'), + '{selectedInterface.name}', + ), currentNode: '{currentNode}', availablePeers: '{availablePeers}', selectedPeers: '{selectedInterface.peers}', diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js index fe4639ad..6d51034a 100644 --- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js +++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js @@ -24,6 +24,10 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { let me = this; return !me.getView().isCreate || get('current.isPveNode'); }, + endpointEmptyText: (get) => + get('current.isPveNode') + ? gettext('Host that peers connect to') + : gettext('host:port this external node is reachable at'), }, }, @@ -58,10 +62,12 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { { xtype: 'proxmoxtextfield', fieldLabel: gettext('Endpoint'), - emptyText: gettext('Host that peers connect to'), labelWidth: 120, name: 'endpoint', allowBlank: false, + bind: { + emptyText: '{endpointEmptyText}', + }, }, { xtype: 'proxmoxtextfield', -- 2.47.3