From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9AE371FF143 for ; Sat, 23 May 2026 23:29:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 663BC1BA91; Sat, 23 May 2026 23:29:15 +0200 (CEST) From: Thomas Lamprecht To: Proxmox VE development discussion , Mira Limbeck Subject: Re: [PATCH v2 storage 12/15] iscsi: add support for non-persistent discovery Date: Sat, 23 May 2026 23:26:14 +0200 Message-ID: <20260523212856.2822353-9-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260430173220.441001-13-m.limbeck@proxmox.com> References: <20260430173220.441001-1-m.limbeck@proxmox.com> <20260430173220.441001-13-m.limbeck@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779571725722 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TFJQTDUFC2T3YZYYAXYBFYFLPX7W5NTL X-Message-ID-Hash: TFJQTDUFC2T3YZYYAXYBFYFLPX7W5NTL X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 30 Apr 2026 19:27:10 +0200, Mira Limbeck wrote: > diff --git a/src/PVE/Storage/ISCSIPlugin.pm b/src/PVE/Storage/ISCSIPlugin.pm > @@ -226,7 +227,7 @@ sub iscsi_discovery { > # In case of multipath we can stop after receiving targets from any available portal > - last if scalar(keys %$res) > 0; > + last if defined($target) && scalar(keys %$res) > 0; $target is declared with `my` inside the outfunc closure a few lines up, so it is out of scope here - this doesn't compile under `use strict` ("Global symbol $target requires explicit package name"). 13/15 rewrites the line to use $target_found, so the final status is again fine, but this commit on its own breaks the build. Worth folding that fix into this commit for bisectability. btw. I like using rebase + exec for ensuring that every commit is clean from code format and testing/build POV. It's slightly nicer in rust projects where just cargo fmt / check / test calls can be used in a generic fashion independent of the specific repo layout, but most of our perl repos are rather uniform in its basic targets nowadays, so something like: git rebase --update-refs -x 'printf "\n-------\n"' \ -x 'git show --no-patch --oneline --no-decorate HEAD' \ -x 'make tidy' \ -x 'make -C src test' \ origin/master should do the trick (btw. --update-refs is normally not required, but essential for stacked branches for (sub) series, and it normally doesn't hurt to pass). We might want to add something like that to the developer wiki, or maybe even add a proper (e.g.) "dev-test" make target that combines the four -x steps (for me my shell history got me covered ^^).