From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5C7011FF143 for ; Sat, 23 May 2026 23:30:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 13AB91C126; Sat, 23 May 2026 23:29:44 +0200 (CEST) From: Thomas Lamprecht To: Proxmox VE development discussion , Mira Limbeck Subject: Re: [PATCH v2 storage 09/15] iscsi: remove stale sessions in non-mapping case Date: Sat, 23 May 2026 23:26:12 +0200 Message-ID: <20260523212856.2822353-7-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260430173220.441001-10-m.limbeck@proxmox.com> References: <20260430173220.441001-1-m.limbeck@proxmox.com> <20260430173220.441001-10-m.limbeck@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779571725606 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4YVDNDF7NCD3NW6VDV2ZYPFG2QN67OZC X-Message-ID-Hash: 4YVDNDF7NCD3NW6VDV2ZYPFG2QN67OZC X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 30 Apr 2026 19:27:07 +0200, Mira Limbeck wrote:=0D > diff --git a/src/PVE/Storage/ISCSIPlugin.pm b/src/PVE/Storage/ISCSIPlugin= .pm=0D > @@ -736,6 +736,41 @@ sub activate_storage {=0D > + # log out of stale sessions=0D > + # should only be needed for the non-mapping case=0D > + if (!$local_cfg->{is_mapping}) {=0D > + for my $target (keys $targets->%*) {=0D > + for my $session ($targets->{$target}->{sessions}->@*) {=0D > + my $portals =3D $targets->{$target}->{portals};=0D > + if (!grep(/^\Q$session->{portal}\E$/, $portals->@*)) {=0D > + my $sid =3D $session->{session_id};=0D > + my $portal =3D $session->{portal};=0D > + print "logging out of stale iscsi session: $sid for = $target via $portal\n";=0D > + my $cmd =3D [=0D > + $ISCSIADM, '--mode', 'session', '--sid', $sid, '= --logout',=0D > + ];=0D > + eval { run_command($cmd); };=0D > + warn "failed to log out of stale session: $@\n" if $= @;=0D =0D In the non-mapping case $portals is whatever discovery returned this cycle= =0D (see 07/15) - driven by the SAN's sendtargets output, or kept as-is if=0D discovery failed. So if the SAN momentarily stops announcing a portal (or=0D discovery partially fails), its live session here gets logged out and the=0D node entry deleted. Under shared LVM-on-iSCSI that can pull a PV out from a= n=0D active VG; under multipath it can remove the last surviving path. It also=0D runs counter to the "keep configured entries, clean up manually" caution=0D added in 07/15.=0D =0D I'd suggest dropping this for now, or reworking it to be opt-in, to act onl= y=0D after a successful full discovery against all portals, to never remove the= =0D last path, and to never remove a session that is a member of an active=0D multipath map.=0D