From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id C7CA11FF143
	for <inbox@lore.proxmox.com>; Sat, 23 May 2026 23:30:17 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 33E291BD93;
	Sat, 23 May 2026 23:29:41 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Mira Limbeck <m.limbeck@proxmox.com>
Subject: Re: [PATCH v2 storage 06/15] iscsi: change functions to handle
 mappings
Date: Sat, 23 May 2026 23:26:09 +0200
Message-ID: <20260523212856.2822353-4-t.lamprecht@proxmox.com>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260430173220.441001-7-m.limbeck@proxmox.com>
References: <20260430173220.441001-1-m.limbeck@proxmox.com>
 <20260430173220.441001-7-m.limbeck@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1779571725380
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.005 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: MGK4IH3JOYCKG5W3JDUTKRZNJDDKHSDI
X-Message-ID-Hash: MGK4IH3JOYCKG5W3JDUTKRZNJDDKHSDI
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Thu, 30 Apr 2026 19:27:04 +0200, Mira Limbeck wrote:=0D
> diff --git a/src/PVE/Storage/ISCSIPlugin.pm b/src/PVE/Storage/ISCSIPlugin=
.pm=0D
> @@ -654,18 +679,26 @@ sub activate_volume {=0D
>      my $device_path =3D $udev_query_path->($real_path);=0D
>      my $resolved_paths =3D $resolve_virtual_devices->($device_path);=0D
>=0D
> -    my $found =3D $check_devices_part_of_target->($resolved_paths, $scfg=
->{target});=0D
> -    die "volume '$volname' not part of target '$scfg->{target}'\n" if !$=
found;=0D
> +    my $local_cfg =3D $get_local_config->($scfg);=0D
> +    my $found =3D 0;=0D
> +    for my $target ($local_cfg->{targets}->%*) {=0D
> +        $found ||=3D $check_devices_part_of_target->($resolved_paths, $t=
arget);=0D
> +        last if $found;=0D
> +    }=0D
> +    die "volume '$volname' not part of any matching target\n" if !$found=
;=0D
=0D
Missing `keys`: ->%* in list context flattens to (target, portals-arrayref,=
=0D
...), so $target also takes the arrayref values and=0D
$check_devices_part_of_target then compares a targetname against an=0D
arrayref. Works by accident for a single target. check_connection() in this=
=0D
same patch uses `keys` correctly - i.e.:=0D
=0D
  -    for my $target ($local_cfg->{targets}->%*) {=0D
  +    for my $target (keys $local_cfg->{targets}->%*) {=0D