From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 108741FF143 for ; Sat, 23 May 2026 23:29:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 347141B563; Sat, 23 May 2026 23:29:11 +0200 (CEST) From: Thomas Lamprecht To: Proxmox VE development discussion , Mira Limbeck Subject: Re: [PATCH v2 storage 02/15] mapping: add base plugin Date: Sat, 23 May 2026 23:26:07 +0200 Message-ID: <20260523212856.2822353-2-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260430173220.441001-3-m.limbeck@proxmox.com> References: <20260430173220.441001-1-m.limbeck@proxmox.com> <20260430173220.441001-3-m.limbeck@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779571725258 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TP7OWY5B3QYDPEUJFGUDRYAAXYTEFHFN X-Message-ID-Hash: TP7OWY5B3QYDPEUJFGUDRYAAXYTEFHFN X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Missing Signed-off-by: on this patch (the other 14 have one).=0D =0D On Thu, 30 Apr 2026 19:27:00 +0200, Mira Limbeck wrote:=0D > diff --git a/src/PVE/Storage/Mapping.pm b/src/PVE/Storage/Mapping.pm=0D > @@ -0,0 +1,44 @@=0D > + if ($entry && $entry->{node} eq $nodename) {=0D > + push $res->@*, $entry;=0D =0D Filtering on node is exactly right for iSCSI, so nothing to change here - j= ust=0D noting for the future multipath angle from the cover: a node-invariant reso= urce=0D (a WWID) would want one cluster-wide entry rather than a `map` line per nod= e, so=0D leaving room for a non-node-filtered lookup here would help then.=0D