From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7BACC1FF143 for ; Sat, 23 May 2026 23:30:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B18571BBFF; Sat, 23 May 2026 23:29:39 +0200 (CEST) From: Thomas Lamprecht To: Proxmox VE development discussion , Mira Limbeck Subject: Re: [PATCH v2 cluster/storage/manager 00/15] storage mapping Date: Sat, 23 May 2026 23:26:06 +0200 Message-ID: <20260523212856.2822353-1-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260430173220.441001-1-m.limbeck@proxmox.com> References: <20260430173220.441001-1-m.limbeck@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779571725159 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OK35ALH7IK2Q6UFPAZP7PGRNE4VBXK2O X-Message-ID-Hash: OK35ALH7IK2Q6UFPAZP7PGRNE4VBXK2O X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Framework and the iSCSI multi-target rework look like going in the right=0D direction to me from a high level POV.=0D =0D The main things that should be fixed:=0D - 10/15: the per-mapping ACL path can't be registered and differs from=0D the write methods.=0D - 09/15: stale-session cleanup can drop a live/last path.=0D =0D Also: discovery now runs every pvestatd cycle for plain iSCSI storages=0D (patch 07 & 08) - a behavior change for existing installs. But see the=0D per-patch replies for more details.=0D =0D btw. this might be especially nice together with the multipath=0D improvements I talked about with Friedrich recently - a few things that=0D might help to prepare for that:=0D =0D - Multipath names a LUN by its WWID, but a mapping here is named by=0D logical-id + (target, portal). Nothing stores the WWID a mapping ends=0D up pointing at, so later there is no easy way to check that all nodes=0D see WWID X over K paths. Storing the WWID in the mapping, or at least=0D leaving room to look it up when activating, would help.=0D =0D - The per-node `targets -> [portals]` that gets resolved is basically=0D the "how many paths should we expect here" info such a check needs.=0D Right now it only lives inside the ISCSIPlugin $get_local_config=0D closure - returning it (or a small helper) would save working it out=0D again later.=0D =0D - A `multipath` mapping type would not really fit the per-node model: a=0D WWID is the same on every node, so it wants one cluster-wide WWID=0D list, not one `map` line per node. Not assuming a per-node `node=3D` is= =0D always needed in the base plugin would make that easier (see reply on=0D 02).=0D =0D Doesn't have to be in your scope now, but I figured I mention it in case=0D it helps for some synergy or whatnot.=0D