From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E612A1FF13B for ; Wed, 20 May 2026 14:52:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 417CA68B5; Wed, 20 May 2026 14:52:05 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH network] ui: sdn: fabrics: drop dead disabled bindings Date: Wed, 20 May 2026 14:51:16 +0200 Message-ID: <20260520125125.251655-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779281473746 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ASWMYTMGAJVWKBU3GEOXTBXHF7226JGU X-Message-ID-Hash: ASWMYTMGAJVWKBU3GEOXTBXHF7226JGU X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The prefix fields used an invalid cbind setup for their disabled state, so the bindings didn't work and editing the fabric prefix was possible. Initially we didn't want the user to be able to update the prefix of a fabric, because we would need to add a mechanism to update all the node ips at the same time. This broke though and they became editable -- which is fine, since you still get an error "node has ip out of prefix". Keep it this way, because editing a fabric without nodes is still useful. Remove the dead disabled bindings while keeping deleteEmpty handling. Fixes: e5e3374273af ("ui: fabrics: edit: make ipv4/6 support generic over fabric panels") Signed-off-by: Gabriel Goller --- www/manager6/sdn/fabrics/FabricEdit.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js index 46c8dd6b0c86..1f7bab362075 100644 --- a/www/manager6/sdn/fabrics/FabricEdit.js +++ b/www/manager6/sdn/fabrics/FabricEdit.js @@ -62,10 +62,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', { name: 'ip_prefix', allowBlank: true, skipEmptyText: true, - cbind: { - disabled: '{!isCreate}', - deleteEmpty: '{!isCreate}', - }, + deleteEmpty: '{!isCreate}', }); } @@ -86,10 +83,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', { name: 'ip6_prefix', allowBlank: true, skipEmptyText: true, - cbind: { - disabled: '{!isCreate}', - deleteEmpty: '{!isCreate}', - }, + deleteEmpty: '{!isCreate}', listeners: { change: function (textbox, value) { let vm = textbox.up('window').getViewModel(); -- 2.47.3