* [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons @ 2026-05-20 12:46 Arthur Bied-Charreton 2026-05-20 12:53 ` Dominik Csapak 2026-05-20 13:43 ` Thomas Lamprecht 0 siblings, 2 replies; 6+ messages in thread From: Arthur Bied-Charreton @ 2026-05-20 12:46 UTC (permalink / raw) To: pve-devel Password manager extensions scan every new <input> element. The flag selector grid creates hundreds of radio buttons through its widgetcolumn, causing the extension to peg the CPU while it checks each one for autofill. Mark the radio inputs with autocomplete="off" and the extension-specific ignore attributes so they are skipped during the scan. Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com> --- www/manager6/form/VMCPUFlagSelector.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js index ea20108d..f8d4caad 100644 --- a/www/manager6/form/VMCPUFlagSelector.js +++ b/www/manager6/form/VMCPUFlagSelector.js @@ -263,16 +263,19 @@ Ext.define('PVE.form.VMCPUFlagSelector', { boxLabelAlign: 'before', inputValue: '-', isFormField: false, + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', }, { checked: true, inputValue: '=', isFormField: false, + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', }, { boxLabel: '+', inputValue: '+', isFormField: false, + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', }, ], }, -- 2.47.3 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons 2026-05-20 12:46 [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons Arthur Bied-Charreton @ 2026-05-20 12:53 ` Dominik Csapak 2026-05-20 12:58 ` David Riley 2026-05-20 13:43 ` Thomas Lamprecht 1 sibling, 1 reply; 6+ messages in thread From: Dominik Csapak @ 2026-05-20 12:53 UTC (permalink / raw) To: Arthur Bied-Charreton, pve-devel i guess this could be ok if it works, but i really dislike having to add 1 to 2 attributes per passwordmanager... isn't the generic 'autocomplete=off' enough? On 5/20/26 2:45 PM, Arthur Bied-Charreton wrote: > Password manager extensions scan every new <input> element. The flag > selector grid creates hundreds of radio buttons through its > widgetcolumn, causing the extension to peg the CPU while it checks each > one for autofill. > > Mark the radio inputs with autocomplete="off" and the extension-specific > ignore attributes so they are skipped during the scan. > > Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com> > --- > www/manager6/form/VMCPUFlagSelector.js | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js > index ea20108d..f8d4caad 100644 > --- a/www/manager6/form/VMCPUFlagSelector.js > +++ b/www/manager6/form/VMCPUFlagSelector.js > @@ -263,16 +263,19 @@ Ext.define('PVE.form.VMCPUFlagSelector', { > boxLabelAlign: 'before', > inputValue: '-', > isFormField: false, > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > }, > { > checked: true, > inputValue: '=', > isFormField: false, > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > }, > { > boxLabel: '+', > inputValue: '+', > isFormField: false, > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > }, > ], > }, ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons 2026-05-20 12:53 ` Dominik Csapak @ 2026-05-20 12:58 ` David Riley 2026-05-20 13:08 ` David Riley 0 siblings, 1 reply; 6+ messages in thread From: David Riley @ 2026-05-20 12:58 UTC (permalink / raw) To: Dominik Csapak, Arthur Bied-Charreton, pve-devel On 5/20/26 2:53 PM, Dominik Csapak wrote: > i guess this could be ok if it works, > but i really dislike having to add 1 to 2 attributes > per passwordmanager... isn't the generic 'autocomplete=off' enough? > Tested this patch and the fix worked for me. I'm using the bitwarden extension on firefox. > > On 5/20/26 2:45 PM, Arthur Bied-Charreton wrote: >> Password manager extensions scan every new <input> element. The flag >> selector grid creates hundreds of radio buttons through its >> widgetcolumn, causing the extension to peg the CPU while it checks each >> one for autofill. >> >> Mark the radio inputs with autocomplete="off" and the extension-specific >> ignore attributes so they are skipped during the scan. >> >> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com> >> --- >> www/manager6/form/VMCPUFlagSelector.js | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js >> index ea20108d..f8d4caad 100644 >> --- a/www/manager6/form/VMCPUFlagSelector.js >> +++ b/www/manager6/form/VMCPUFlagSelector.js >> @@ -263,16 +263,19 @@ Ext.define('PVE.form.VMCPUFlagSelector', { >> boxLabelAlign: 'before', >> inputValue: '-', >> isFormField: false, >> + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', >> }, >> { >> checked: true, >> inputValue: '=', >> isFormField: false, >> + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', >> }, >> { >> boxLabel: '+', >> inputValue: '+', >> isFormField: false, >> + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', >> }, >> ], >> }, > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons 2026-05-20 12:58 ` David Riley @ 2026-05-20 13:08 ` David Riley 0 siblings, 0 replies; 6+ messages in thread From: David Riley @ 2026-05-20 13:08 UTC (permalink / raw) To: Dominik Csapak, Arthur Bied-Charreton, pve-devel On 5/20/26 2:59 PM, David Riley wrote: > On 5/20/26 2:53 PM, Dominik Csapak wrote: >> i guess this could be ok if it works, >> but i really dislike having to add 1 to 2 attributes >> per passwordmanager... isn't the generic 'autocomplete=off' enough? >> > Tested this patch and the fix worked for me. > I'm using the bitwarden extension on firefox. Did a quick follow up test using only: `inputAttrTpl: 'autocomplete="off"'` for all three instances, but this does not resolve the issue for me. >> >> On 5/20/26 2:45 PM, Arthur Bied-Charreton wrote: >>> Password manager extensions scan every new <input> element. The flag >>> selector grid creates hundreds of radio buttons through its >>> widgetcolumn, causing the extension to peg the CPU while it checks each >>> one for autofill. >>> >>> Mark the radio inputs with autocomplete="off" and the extension-specific >>> ignore attributes so they are skipped during the scan. >>> >>> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com> >>> --- >>> www/manager6/form/VMCPUFlagSelector.js | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js >>> index ea20108d..f8d4caad 100644 >>> --- a/www/manager6/form/VMCPUFlagSelector.js >>> +++ b/www/manager6/form/VMCPUFlagSelector.js >>> @@ -263,16 +263,19 @@ Ext.define('PVE.form.VMCPUFlagSelector', { >>> boxLabelAlign: 'before', >>> inputValue: '-', >>> isFormField: false, >>> + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', >>> }, >>> { >>> checked: true, >>> inputValue: '=', >>> isFormField: false, >>> + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', >>> }, >>> { >>> boxLabel: '+', >>> inputValue: '+', >>> isFormField: false, >>> + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', >>> }, >>> ], >>> }, >> >> >> >> >> > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons 2026-05-20 12:46 [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons Arthur Bied-Charreton 2026-05-20 12:53 ` Dominik Csapak @ 2026-05-20 13:43 ` Thomas Lamprecht 2026-05-20 14:07 ` Arthur Bied-Charreton 1 sibling, 1 reply; 6+ messages in thread From: Thomas Lamprecht @ 2026-05-20 13:43 UTC (permalink / raw) To: Arthur Bied-Charreton, pve-devel Am 20.05.26 um 14:45 schrieb Arthur Bied-Charreton: > Password manager extensions scan every new <input> element. The flag > selector grid creates hundreds of radio buttons through its > widgetcolumn, causing the extension to peg the CPU while it checks each > one for autofill. > > Mark the radio inputs with autocomplete="off" and the extension-specific > ignore attributes so they are skipped during the scan. > > Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com> > --- > www/manager6/form/VMCPUFlagSelector.js | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js > index ea20108d..f8d4caad 100644 > --- a/www/manager6/form/VMCPUFlagSelector.js > +++ b/www/manager6/form/VMCPUFlagSelector.js > @@ -263,16 +263,19 @@ Ext.define('PVE.form.VMCPUFlagSelector', { > boxLabelAlign: 'before', > inputValue: '-', > isFormField: false, > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > }, > { > checked: true, > inputValue: '=', > isFormField: false, > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > }, > { > boxLabel: '+', > inputValue: '+', > isFormField: false, > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > }, > ], > }, oof, those plugins are not always a blessing... I'll skip this for now, as such changes can IME have slightly subtle effects, and besides that it would be nice to report this upstream where these plugins are developed, as IMO they should cope with that better (not that I expect it to happen soon, but still, if they don't know, they don't know). And if we have to go this route, I'd prefer avoiding some code duplication here by using defaults, i.e. doing something like: diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js index ea20108da..e2e7c86ac 100644 --- a/www/manager6/form/VMCPUFlagSelector.js +++ b/www/manager6/form/VMCPUFlagSelector.js @@ -257,22 +257,24 @@ Ext.define('PVE.form.VMCPUFlagSelector', { //view.checkChange(); }, }, + defaults: { + isFormField: false, + inputAttrTpl: + 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', + }, items: [ { boxLabel: '-', boxLabelAlign: 'before', inputValue: '-', - isFormField: false, }, { checked: true, inputValue: '=', - isFormField: false, }, { boxLabel: '+', inputValue: '+', - isFormField: false, }, ], }, ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons 2026-05-20 13:43 ` Thomas Lamprecht @ 2026-05-20 14:07 ` Arthur Bied-Charreton 0 siblings, 0 replies; 6+ messages in thread From: Arthur Bied-Charreton @ 2026-05-20 14:07 UTC (permalink / raw) To: Thomas Lamprecht; +Cc: pve-devel On Wed, May 20, 2026 at 03:43:03PM +0200, Thomas Lamprecht wrote: > Am 20.05.26 um 14:45 schrieb Arthur Bied-Charreton: > > Password manager extensions scan every new <input> element. The flag > > selector grid creates hundreds of radio buttons through its > > widgetcolumn, causing the extension to peg the CPU while it checks each > > one for autofill. > > > > Mark the radio inputs with autocomplete="off" and the extension-specific > > ignore attributes so they are skipped during the scan. > > > > Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com> > > --- > > www/manager6/form/VMCPUFlagSelector.js | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js > > index ea20108d..f8d4caad 100644 > > --- a/www/manager6/form/VMCPUFlagSelector.js > > +++ b/www/manager6/form/VMCPUFlagSelector.js > > @@ -263,16 +263,19 @@ Ext.define('PVE.form.VMCPUFlagSelector', { > > boxLabelAlign: 'before', > > inputValue: '-', > > isFormField: false, > > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > > }, > > { > > checked: true, > > inputValue: '=', > > isFormField: false, > > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > > }, > > { > > boxLabel: '+', > > inputValue: '+', > > isFormField: false, > > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > > }, > > ], > > }, > > oof, those plugins are not always a blessing... I'll skip this for now, as such > changes can IME have slightly subtle effects, and besides that it would be nice > to report this upstream where these plugins are developed, as IMO they should > cope with that better (not that I expect it to happen soon, but still, if they > don't know, they don't know). > ACK. I agree that this is not ideal, however those attributes are the only officially documented way to actually prevent autocomplete for these PW managers [0][1][2]. I started working on a different approach for the CPU flags list that should allow us to use buffered rendering by making all rows the same height, which would also fix this problem. I am not sure how much sense it would make to report this upstream though. The extensions deliberately ignore the autocomplete attribute because some websites where users expect autocomplete use it to prevent browsers from saving passwords (from a comment by a BitWarden dev [3]). [0] https://developer.1password.com/docs/web/compatible-website-design/#ignore-offers-to-save-or-fill-specific-fields [1] https://support.lastpass.com/s/document-item?language=en_US&bundleId=lastpass&topicId=LastPass%2Fc_lp_prevent_fields_from_being_filled_automatically.html&_LANG=enus [2] https://bitwarden.com/help/releasenotes/#2021-06-29 [3] https://github.com/bitwarden/clients/issues/1469\#issuecomment-754188483 > And if we have to go this route, I'd prefer avoiding some code duplication here > by using defaults, i.e. doing something like: > > diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js > index ea20108da..e2e7c86ac 100644 > --- a/www/manager6/form/VMCPUFlagSelector.js > +++ b/www/manager6/form/VMCPUFlagSelector.js > @@ -257,22 +257,24 @@ Ext.define('PVE.form.VMCPUFlagSelector', { > //view.checkChange(); > }, > }, > + defaults: { > + isFormField: false, > + inputAttrTpl: > + 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > + }, > items: [ > { > boxLabel: '-', > boxLabelAlign: 'before', > inputValue: '-', > - isFormField: false, > }, > { > checked: true, > inputValue: '=', > - isFormField: false, > }, > { > boxLabel: '+', > inputValue: '+', > - isFormField: false, > }, > ], > }, Noted, thanks for the feedback! ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-05-20 14:07 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-05-20 12:46 [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons Arthur Bied-Charreton 2026-05-20 12:53 ` Dominik Csapak 2026-05-20 12:58 ` David Riley 2026-05-20 13:08 ` David Riley 2026-05-20 13:43 ` Thomas Lamprecht 2026-05-20 14:07 ` Arthur Bied-Charreton
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox