From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1F7661FF13B for ; Wed, 20 May 2026 11:56:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EFB7B1F3A3; Wed, 20 May 2026 11:56:21 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH manager] network-interface-pinning: ignore comments in .link parser Date: Wed, 20 May 2026 11:55:45 +0200 Message-ID: <20260520095613.86640-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779270962270 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: M7VVFMMLT26FWCSGWICGA7IJAYST5AFT X-Message-ID-Hash: M7VVFMMLT26FWCSGWICGA7IJAYST5AFT X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The parser for the systemd .link files didn't support comments. This means executing `pve-network-interface-pinning generate` after pinning interfaces with the installer was broken because we add a comment there. Skip lines starting with '#' or ';' while parsing (according to `man systemd.syntax`). Reported-by: Robert Obkircher Signed-off-by: Gabriel Goller --- Note that this bug is old, it was already there in the previous release. PVE/CLI/pve_network_interface_pinning.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/pve_network_interface_pinning.pm b/PVE/CLI/pve_network_interface_pinning.pm index 8e419603be60..9dff181dcd9d 100644 --- a/PVE/CLI/pve_network_interface_pinning.pm +++ b/PVE/CLI/pve_network_interface_pinning.pm @@ -158,7 +158,7 @@ my sub parse_link_file { my $data = {}; for my $line (@lines) { - next if $line =~ m/^\s*$/; + next if $line =~ m/^\s*(?:[#;]|$)/; if ($line =~ m/^\[(Match|Link)\]$/) { $section = $1; -- 2.47.3