From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6B1031FF13B for ; Wed, 20 May 2026 10:11:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A9A3D1C76E; Wed, 20 May 2026 10:11:24 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH manager 2/3] ui: sdn: redistribution grid: make style consistent Date: Wed, 20 May 2026 10:10:41 +0200 Message-ID: <20260520081047.756068-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260520081047.756068-1-d.csapak@proxmox.com> References: <20260520081047.756068-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QD7J6CCXR44C4N7OQPZPIYYSGNE5ZDUK X-Message-ID-Hash: QD7J6CCXR44C4N7OQPZPIYYSGNE5ZDUK X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: as with the other grids that are editable: * remove button instead of remove action * add button below and on the left side in this case also add an empty text and add a minimum height to show it. (data needs to be initialized for it to show correctly) Signed-off-by: Dominik Csapak --- .../sdn/fabrics/RedistributionGrid.js | 31 +++++++++++-------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/www/manager6/sdn/fabrics/RedistributionGrid.js b/www/manager6/sdn/fabrics/RedistributionGrid.js index 7dfd4d49..34af5375 100644 --- a/www/manager6/sdn/fabrics/RedistributionGrid.js +++ b/www/manager6/sdn/fabrics/RedistributionGrid.js @@ -15,20 +15,26 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', { store: { model: 'PVE.sdn.Fabric.Redistribution', + data: [], }, - tbar: [ - '->', + bbar: [ { text: gettext('Add'), handler: 'addRedistribution', }, ], + minHeight: 100, + border: false, columns: [], + viewConfig: { + emptyText: gettext('No entries configured'), + }, + controller: { xclass: 'Ext.app.ViewController', @@ -44,8 +50,9 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', { me.handleUpdate(); }, - deleteRedistribution: function (table, rI, cI, item, e, rec) { + deleteRedistribution: function (btn) { let me = this; + let rec = btn.getWidgetRecord(); me.getView().getStore().remove(rec); me.handleUpdate(); }, @@ -108,16 +115,14 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', { }, ...me.getAdditionalColumns(), { - text: gettext('Action'), - xtype: 'actioncolumn', - width: 100, - items: [ - { - tooltip: gettext('Delete'), - handler: 'deleteRedistribution', - iconCls: 'fa critical fa-trash-o', - }, - ], + xtype: 'widgetcolumn', + width: 40, + widget: { + xtype: 'button', + tooltip: gettext('Delete'), + handler: 'deleteRedistribution', + iconCls: 'fa fa-trash-o', + }, }, ]; -- 2.47.3