[PATCH manager] ui: cpu flags: add clear trigger to search field

[PATCH manager] ui: cpu flags: add clear trigger to search field

[Dominik Csapak]

to make it easier to clear it again.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/form/VMCPUFlagSelector.js | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
index 6996d1a5..73ee5e30 100644
--- a/www/manager6/form/VMCPUFlagSelector.js
+++ b/www/manager6/form/VMCPUFlagSelector.js
@@ -314,12 +314,24 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
                         emptyText: gettext('Search name or description'),
                         submitValue: false,
                         width: 240,
+                        triggers: {
+                            clear: {
+                                cls: 'pmx-clear-trigger',
+                                weight: -1,
+                                hidden: true,
+                                handler: function () {
+                                    this.setValue('');
+                                    this.triggers.clear.setVisible(false);
+                                },
+                            },
+                        },
                         listeners: {
                             change: {
                                 buffer: 100,
                                 fn: function (field, value) {
                                     let store = field.up('grid').getStore();
                                     if (value) {
+                                        field.triggers.clear.setVisible(true);
                                         let lv = value.toLowerCase();
                                         store.addFilter({
                                             id: 'search-filter',
@@ -333,6 +345,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
                                             },
                                         });
                                     } else {
+                                        field.triggers.clear.setVisible(false);
                                         store.removeFilter('search-filter');
                                     }
                                 },
-- 
2.47.3

applied: [PATCH manager] ui: cpu flags: add clear trigger to search field

[Thomas Lamprecht]

On Wed, 20 May 2026 09:35:49 +0200, Dominik Csapak wrote:
> to make it easier to clear it again.

Applied, thanks!

btw. I recently factored out the a few times used pattern of such search fields
into a pveRecordSearchField widget (see form/RecordSearchField.js) and now
adopted the clear trigger there and used in in a few other fitting places now.
FWIW, I hesitated to add this to widget-toolkit, as doing that to early adds a
bit extra friction on future fixes and it's still a code reuse win as is.

[1/1] ui: cpu flags: add clear trigger to search field
      commit: 8ad1e5a8919988a42d4791d2bc8eca6c625285c6

Re: applied: [PATCH manager] ui: cpu flags: add clear trigger to search field

[Dominik Csapak]

On 5/20/26 1:55 PM, Thomas Lamprecht wrote:
> On Wed, 20 May 2026 09:35:49 +0200, Dominik Csapak wrote:
>> to make it easier to clear it again.
> 
> Applied, thanks!
> 
> btw. I recently factored out the a few times used pattern of such search fields
> into a pveRecordSearchField widget (see form/RecordSearchField.js) and now
> adopted the clear trigger there and used in in a few other fitting places now.
> FWIW, I hesitated to add this to widget-toolkit, as doing that to early adds a
> bit extra friction on future fixes and it's still a code reuse win as is.

thanks!

had a short look and the refactor of that looks very nice!
I can already think of  a few places where we could reuse that in
PVE/PBS.

> 
> [1/1] ui: cpu flags: add clear trigger to search field
>        commit: 8ad1e5a8919988a42d4791d2bc8eca6c625285c6