From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B1A1E1FF141 for ; Tue, 19 May 2026 16:06:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A416C87EA; Tue, 19 May 2026 16:06:29 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 2/3] custom cpu models: do not allow deleting 'reported-model' Date: Tue, 19 May 2026 16:06:22 +0200 Message-ID: <20260519140623.594472-3-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260519140623.594472-1-a.bied-charreton@proxmox.com> References: <20260519140623.594472-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.135 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: FUJFXLHQYZ2XZWRJRRF3JQ6S3DAPKQUB X-Message-ID-Hash: FUJFXLHQYZ2XZWRJRRF3JQ6S3DAPKQUB X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Now that reported-model is required on creation, prevent it from being removed via the delete parameter on PUT. Signed-off-by: Arthur Bied-Charreton Suggested-by: Fiona Ebner --- PVE/API2/Cluster/Qemu/CustomCPUModels.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Cluster/Qemu/CustomCPUModels.pm b/PVE/API2/Cluster/Qemu/CustomCPUModels.pm index 4ba04180..fdeb2ce3 100644 --- a/PVE/API2/Cluster/Qemu/CustomCPUModels.pm +++ b/PVE/API2/Cluster/Qemu/CustomCPUModels.pm @@ -173,6 +173,7 @@ __PACKAGE__->register_method({ if ($delete) { $delete = [PVE::Tools::split_list($delete)]; die "cannot delete 'cputype'\n" if grep { $_ eq 'cputype' } @$delete; + die "cannot delete 'reported-model'\n" if grep { $_ eq 'reported-model' } @$delete; } (my $name = $param->{cputype}) =~ s/^custom-//; -- 2.47.3