From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (unknown [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9E9651FF141 for ; Tue, 19 May 2026 14:38:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F2D2D626C; Tue, 19 May 2026 14:37:48 +0200 (CEST) From: Shannon Sterz To: pve-devel@lists.proxmox.com Subject: [PATCH manager] ui: vnet edit: disable tag and vlan aware fields instead of hiding them Date: Tue, 19 May 2026 14:37:41 +0200 Message-ID: <20260519123741.210988-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779194249187 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4G446ISBAOSQOSJVRRPYQBMMKRSLNTRN X-Message-ID-Hash: 4G446ISBAOSQOSJVRRPYQBMMKRSLNTRN X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: this improves ux as users unfamiliar with the ui can now tell that this would be the correct place to set these values, even if the currently select zone does not support them. particularly important when creating new vnets, where the controller type is not yet selected and both fields would be hidden at first. Signed-off-by: Shannon Sterz --- www/manager6/sdn/VnetEdit.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/www/manager6/sdn/VnetEdit.js b/www/manager6/sdn/VnetEdit.js index 34e382c72..f3d66ce9c 100644 --- a/www/manager6/sdn/VnetEdit.js +++ b/www/manager6/sdn/VnetEdit.js @@ -101,18 +101,18 @@ Ext.define('PVE.sdn.VnetInputPanel', { let tagField = me.down('#sdnVnetTagField'); if (!zoneType || zoneType === 'simple') { - tagField.setVisible(false); + tagField.setDisabled(true); tagField.setValue(''); } else { - tagField.setVisible(true); + tagField.setDisabled(false); } let vlanField = me.down('#sdnVnetVlanAwareField'); if (!zoneType || zoneType === 'evpn') { - vlanField.setVisible(false); + vlanField.setDisabled(true); vlanField.setValue(''); } else { - vlanField.setVisible(true); + vlanField.setDisabled(false); } }, }); -- 2.47.3