From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9129C1FF141 for ; Tue, 19 May 2026 13:07:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 58186275F; Tue, 19 May 2026 13:07:23 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage v3 02/11] plugin: volume snapshot info: also return virtual size Date: Tue, 19 May 2026 13:06:27 +0200 Message-ID: <20260519110646.25060-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260519110646.25060-1-f.ebner@proxmox.com> References: <20260519110646.25060-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779188795688 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OPFZWD7EVYUPJFHGXMFKVP7HQBWRXWKD X-Message-ID-Hash: OPFZWD7EVYUPJFHGXMFKVP7HQBWRXWKD X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For LVM storages using 'snapshot-as-volume-chain', it's necessary to check that the size for the LV of the target snapshot volume is large enough before doing a commit operation. Returning the virtual size of the volume at the time the snapshot was taken in the result of volume_snapshot_info() makes this easy to check. Signed-off-by: Fiona Ebner --- src/PVE/Storage/LVMPlugin.pm | 1 + src/PVE/Storage/Plugin.pm | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 443d292..6c5c96c 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -924,6 +924,7 @@ sub volume_snapshot_info { $info->{$snapname}->{file} = $snapfile; $info->{$snapname}->{volname} = "$snapvolname"; $info->{$snapname}->{volid} = "$storeid:$snapvolname"; + $info->{$snapname}->{'virtual-size'} = $snap->{'virtual-size'}; my $parentfile = $snap->{'backing-filename'}; if ($parentfile) { diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 1c5b0fd..b0ee347 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -1834,6 +1834,8 @@ Required values are: =item C: The volume ID of the external snapshot volume. +=item C: The virtual size of the volume recorded by the snapshot. + =item C: The name of the child snapshot in the volume chain. Not set if there is no child. =item C: The name of the parent snapshot in the volume chain. Not set if there is no parent. @@ -1913,6 +1915,7 @@ sub volume_snapshot_info { $info->{$snapname}->{file} = $snapfile; $info->{$snapname}->{volname} = "$snapvolname"; $info->{$snapname}->{volid} = "$storeid:$snapvolname"; + $info->{$snapname}->{'virtual-size'} = $snap->{'virtual-size'}; $info->{$snapname}->{ext} = 1; my $parentfile = $snap->{'backing-filename'}; -- 2.47.3