From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 166931FF141 for ; Tue, 19 May 2026 09:51:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0CD9E3333A; Tue, 19 May 2026 09:51:12 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server] cpu models: only include custom models on x86_64 Date: Tue, 19 May 2026 09:51:09 +0200 Message-ID: <20260519075109.156258-1-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.131 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: RLL7M6VQPBTCKJAIMGO5VFOKL7X5IPHC X-Message-ID-Hash: RLL7M6VQPBTCKJAIMGO5VFOKL7X5IPHC X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The custom CPU models config does not currently expose a way to specify an arch and it defaults to x86_64. Only include custom models if $arch is set to x86_64 to prevent listing x86_64-only custom models in the CPU model selector for arm VMs. Signed-off-by: Arthur Bied-Charreton --- src/PVE/QemuServer/CPUConfig.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/QemuServer/CPUConfig.pm b/src/PVE/QemuServer/CPUConfig.pm index 10f7729d..b037a34e 100644 --- a/src/PVE/QemuServer/CPUConfig.pm +++ b/src/PVE/QemuServer/CPUConfig.pm @@ -572,6 +572,8 @@ sub add_cpu_json_properties($prop) { sub get_cpu_models($include_custom, $arch = undef) { $arch //= get_host_arch(); + $include_custom = 0 if $arch ne 'x86_64'; + my $cpu_vendor_list = get_cpu_models_by_arch($arch); my $models = []; -- 2.47.3