From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EA88D1FF14C for ; Fri, 15 May 2026 14:04:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F302AB91D; Fri, 15 May 2026 14:04:30 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH frr v2 0/3] Backport FRR EVPN local RT2 leaking fixes Date: Fri, 15 May 2026 14:03:44 +0200 Message-ID: <20260515120351.395649-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778846628780 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YRQTMGLKYWJXWXHCI6YHIIFDSDGOTWVT X-Message-ID-Hash: YRQTMGLKYWJXWXHCI6YHIIFDSDGOTWVT X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since packaging 10.6.1, we also pull in the EVPN local RT2 leaking patches (which are applied on upstream master). The RT2 route leaking PR seems to have some race-condition-related problems, namely a crash at bgp router shutdown and one case in which the rt2 route is not leaked (see the last comment at #20005 [1]). I was not able to reproduce both of these issues, but they seem to be fixed in the upstream CI with #21844 [2], which solves multiple memory-related issues in multiple dameons. This PR also needs the #21511 [3] PR as a prerequisite. In order to be on the safe side, pull these in. The backporting was a bit of a struggle, because frr-10.6.1..master now also contains the new BGP-LS address-family (again, after it was reverted out of 10.5 :)) which changes a lot of core bgp structures. [1]: https://github.com/FRRouting/frr/pull/20005 [2]: https://github.com/FRRouting/frr/pull/21844 [3]: https://github.com/FRRouting/frr/pull/21511 Changelog: v2: * instead of absorbing the fix into the commits of #20005, cherry pick the fixing commit from #21511 frr: Gabriel Goller (3): frr: backport "bgpd: fix valgrind memory leaks on daemon shutdown" (#21511) frr: backport the "Memory leak problems." (#21844) upstream PR bump to version 10.6.1-1+pve2 debian/changelog | 6 + debian/patches/series | 21 + ...rind-memory-leaks-on-daemon-shutdown.patch | 89 ++ ...nup-complaint-about-unneeded-destroy.patch | 77 ++ ...p-termination-cleanup-of-memory-leak.patch | 47 + .../0008-lib-ferr-memory-leaked.patch | 48 + ...fpm_listener-has-signal-handlers-now.patch | 55 ++ ...g-file-isisd.log-from-all-isis-tests.patch | 883 ++++++++++++++++++ ...-tests-Tell-fpm_listener-to-shutdown.patch | 52 ++ ...sd-Clean-up-and-memory-leaks-in-isis.patch | 324 +++++++ ...gpd-Cleanup-memory-leaks-on-shutdown.patch | 608 ++++++++++++ ...ipd-Cleanup-memory-leaks-on-shutdown.patch | 58 ++ ...-termination-cleanup-of-memory-leaks.patch | 126 +++ ...eanup-nhrpd-termination-memory-leaks.patch | 105 +++ ...rpd-memory-leaks-on-shutdown-cleanup.patch | 80 ++ .../0018-ospfd-memory-leaks-on-shutdown.patch | 38 + ...ry-leaks-in-shutdown-in-affinitymaps.patch | 32 + ...bra-cleanup-memory-leaks-on-shutdown.patch | 175 ++++ ...-ldpd-Fixup-memory-leaks-on-shutdown.patch | 207 ++++ .../0022-Cleanup-snmp-memory-leaks.patch | 121 +++ ...cleanup-of-leaked-memory-on-shutdown.patch | 41 + ...opotest-fail-if-a-memory-leak-is-det.patch | 126 +++ ...hash_clean_and_free-remove-hash_free.patch | 480 ++++++++++ 23 files changed, 3799 insertions(+) create mode 100644 debian/patches/upstream/0005-bgpd-fix-valgrind-memory-leaks-on-daemon-shutdown.patch create mode 100644 debian/patches/upstream/0006-pim6d-cleanup-complaint-about-unneeded-destroy.patch create mode 100644 debian/patches/upstream/0007-lib-nexthop-group-termination-cleanup-of-memory-leak.patch create mode 100644 debian/patches/upstream/0008-lib-ferr-memory-leaked.patch create mode 100644 debian/patches/upstream/0009-zebra-fpm_listener-has-signal-handlers-now.patch create mode 100644 debian/patches/upstream/0010-tests-Remove-log-file-isisd.log-from-all-isis-tests.patch create mode 100644 debian/patches/upstream/0011-tests-Tell-fpm_listener-to-shutdown.patch create mode 100644 debian/patches/upstream/0012-isisd-Clean-up-and-memory-leaks-in-isis.patch create mode 100644 debian/patches/upstream/0013-bgpd-Cleanup-memory-leaks-on-shutdown.patch create mode 100644 debian/patches/upstream/0014-ripd-Cleanup-memory-leaks-on-shutdown.patch create mode 100644 debian/patches/upstream/0015-pbrd-termination-cleanup-of-memory-leaks.patch create mode 100644 debian/patches/upstream/0016-nhrpd-Cleanup-nhrpd-termination-memory-leaks.patch create mode 100644 debian/patches/upstream/0017-sharpd-memory-leaks-on-shutdown-cleanup.patch create mode 100644 debian/patches/upstream/0018-ospfd-memory-leaks-on-shutdown.patch create mode 100644 debian/patches/upstream/0019-lib-Cleanup-memory-leaks-in-shutdown-in-affinitymaps.patch create mode 100644 debian/patches/upstream/0020-zebra-cleanup-memory-leaks-on-shutdown.patch create mode 100644 debian/patches/upstream/0021-ldpd-Fixup-memory-leaks-on-shutdown.patch create mode 100644 debian/patches/upstream/0022-Cleanup-snmp-memory-leaks.patch create mode 100644 debian/patches/upstream/0023-pimd-cleanup-of-leaked-memory-on-shutdown.patch create mode 100644 debian/patches/upstream/0024-tests-make-the-topotest-fail-if-a-memory-leak-is-det.patch create mode 100644 debian/patches/upstream/0025-Use-hash_clean_and_free-remove-hash_free.patch Summary over all repositories: 23 files changed, 3799 insertions(+), 0 deletions(-) -- Generated by murpp 0.11.0