From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9F8121FF14C for ; Fri, 15 May 2026 10:54:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 45328111CF; Fri, 15 May 2026 10:54:00 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH manager v3 11/13] ui: qemu: hardware view: separate nics into own grid Date: Fri, 15 May 2026 10:44:29 +0200 Message-ID: <20260515085349.1123127-12-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260515085349.1123127-1-d.csapak@proxmox.com> References: <20260515085349.1123127-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: U5ZIPXTBTB5JJVWHSIWSVRPDCDYSLV3N X-Message-ID-Hash: U5ZIPXTBTB5JJVWHSIWSVRPDCDYSLV3N X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: by using the newly added HardwareNetGrid and ConfigRemoveButton. Signed-off-by: Dominik Csapak --- www/manager6/qemu/HardwareView.js | 67 +++++++++++++++++++++++++++---- 1 file changed, 59 insertions(+), 8 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 48c54a6c..e888bb46 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manager6/qemu/HardwareView.js @@ -657,7 +657,7 @@ Ext.define('PVE.qemu.HardwareView', { url: `/api2/json/nodes/${nodename}/qemu/${vmid}/pending`, interval: 5000, rows, - filters: [(rec) => !diskGridFilter(rec)], + filters: [(rec) => !diskGridFilter(rec), (rec) => !PVE.Utils.keyIsNic(rec.data.key)], }); let onSelectionChange = function (sm, selected) { @@ -733,13 +733,6 @@ Ext.define('PVE.qemu.HardwareView', { disabled: !caps.vms['VM.Config.CDROM'], handler: editorFactory('CDEdit'), }, - { - text: gettext('Network Device'), - itemId: 'addNet', - iconCls: 'fa fa-fw fa-exchange black', - disabled: !caps.vms['VM.Config.Network'], - handler: editorFactory('NetworkEdit'), - }, { text: gettext('USB Device'), itemId: 'addUsb', @@ -1024,6 +1017,64 @@ Ext.define('PVE.qemu.HardwareView', { }, ], }, + // spacer with bottom border + { + xtype: 'panel', + border: true, + height: 1, + margin: '20 0 0 0', + }, + { + xtype: 'pveHardwareNetGrid', + rstore: me.rstore, + store: { + sorter: sorterFn, + }, + renderKey: function () { + let hardwareGrid = me.lookup('hardwareGrid'); + return hardwareGrid.renderKey(...arguments); + }, + listeners: { + itemdblclick: run_editor, + selectionchange: onSelectionChange, + }, + tbar: [ + { + text: gettext('Add'), + itemId: 'addNet', + disabled: !caps.vms['VM.Config.Network'], + handler: editorFactory('NetworkEdit'), + }, + { + xtype: 'proxmoxButton', + text: gettext('Edit'), + disabled: true, + enableFn: (rec) => + diskCap && !rec.data.deleted && !!rows[rec.data.key].editor, + handler: run_editor, + }, + { + xtype: 'pveConfigRemoveButton', + baseurl, + rows, + reloadCallback: () => me.reload(), + renderKey: function () { + return me.lookup('hardwareGrid').renderKey(...arguments); + }, + enableFn: (rec) => + caps.vms['VM.Config.Network'] && + !rec.data.deleted && + !rows[rec.data.key].never_delete, + }, + { + xtype: 'pvePendingRevertButton', + apiurl: '/api2/extjs/' + baseurl, + parentXType: 'pvePendingGrid', + enableFn: (rec) => !!rec.data.deleted || !!rec.data.pending, + reloadCallback: () => me.reload(), + }, + ], + }, ], }); -- 2.47.3