From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6E77F1FF146 for ; Tue, 12 May 2026 15:49:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4E45315269; Tue, 12 May 2026 15:49:50 +0200 (CEST) From: David Riley To: pve-devel@lists.proxmox.com Subject: [PATCH manager/storage 0/2] fix #3936: add validation for ZFS blocksize Date: Tue, 12 May 2026 15:48:50 +0200 Message-ID: <20260512134852.142044-1-d.riley@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778593640107 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.350 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VJXRZY2LDRCNVGVJ4TQEKTWFKYAW4ACW X-Message-ID-Hash: VJXRZY2LDRCNVGVJ4TQEKTWFKYAW4ACW X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Riley X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This patch series fixes #3936 [0] by implementing validation for the ZFS blocksize parameter in both the backend API and the frontend UI. Currently, providing an invalid blocksize (e.g., a non-power-of-two or a value outside the supported range) does not result in an immediate API error and therefore delays the failure to the volume creation. This patch series ensures that invalid configurations are caught early. Validation [1][2]: * Range: 512 bytes to 16 MiB. * Format: Allow positive integers with optional 'k' or 'm' suffix. * Constraint: Must be a power of two. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=3936 [1] https://openzfs.github.io/openzfs-docs/man/v2.4/7/zfsprops.7.html#volblocksize [2] https://openzfs.github.io/openzfs-docs/man/v2.4/7/zfsprops.7.html#recordsize pve-manager: David Riley (1): fix #3936: ui: storage: add validation for ZFS blocksize www/manager6/Utils.js | 34 +++++++++++++++++++++++++++++ www/manager6/storage/ZFSEdit.js | 1 + www/manager6/storage/ZFSPoolEdit.js | 1 + 3 files changed, 36 insertions(+) pve-storage: David Riley (1): fix #3936: api: add zfs-blocksize format src/PVE/Storage/Plugin.pm | 34 ++++++++++++++++++++++++++++++++ src/PVE/Storage/ZFSPoolPlugin.pm | 1 + 2 files changed, 35 insertions(+) Summary over all repositories: 5 files changed, 71 insertions(+), 0 deletions(-) -- Generated by murpp 0.11.0