From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 051F01FF133 for ; Mon, 11 May 2026 11:49:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 320AC113AC; Mon, 11 May 2026 11:47:54 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager v3 05/17] manager: report all reasons when resources are blocked from migration Date: Mon, 11 May 2026 11:46:26 +0200 Message-ID: <20260511094707.142930-6-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260511094707.142930-1-d.kral@proxmox.com> References: <20260511094707.142930-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778492723092 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [manager.pm] Message-ID-Hash: JZ7T3BREFYWHMOHOZY7ITLBEDLZXIMHC X-Message-ID-Hash: JZ7T3BREFYWHMOHOZY7ITLBEDLZXIMHC X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: PVE::HA::Config::get_resource_motion_info(...) already reports all reasons to callers, so log that information in the HA Manager as well. Signed-off-by: Daniel Kral Reviewed-by: Fiona Ebner --- changes v2 -> v3: - none src/PVE/HA/Manager.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index 559fc4fa..af14ea74 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -586,6 +586,7 @@ sub queue_resource_motion { my $resource_affinity = $self->{compiled_rules}->{'resource-affinity'}; my ($together, $separate) = get_affinitive_resources($resource_affinity, $sid); + my $blocked_from_migration; for my $csid (sort keys %$separate) { next if !defined($ss->{$csid}); next if $ss->{$csid}->{state} eq 'ignored'; @@ -598,9 +599,11 @@ sub queue_resource_motion { . " negative affinity with service '$sid'", ); - return; # one negative resource affinity is enough to not execute migration + $blocked_from_migration = 1; } + return if $blocked_from_migration; + $haenv->log('info', "got crm command: $cmd"); $ss->{$sid}->{cmd} = [$task, $target]; -- 2.47.3