From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 544801FF13F for ; Thu, 07 May 2026 13:24:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 92F0914D56; Thu, 7 May 2026 13:24:21 +0200 (CEST) From: Daniel Herzig To: pve-devel@lists.proxmox.com Subject: [PATCH container] fix #7568: ensure new vmid in pve ipams when cloning containers Date: Thu, 7 May 2026 13:23:41 +0200 Message-ID: <20260507112341.268585-1-d.herzig@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.414 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Message-ID-Hash: O7ORD77Y3JITXBGJVQOME4LWVDFIMIKE X-Message-ID-Hash: O7ORD77Y3JITXBGJVQOME4LWVDFIMIKE X-MailFrom: dherzig@emma.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This patch addresses the incorrect application of the original vmid to cloned containers in pve ipams, which results in duplicate vmid entries in the `/cluster/sdn/ipams/pve/status` endpoint. Signed-off-by: Daniel Herzig --- THX @Gabriel for the offline input. src/PVE/API2/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 838dd76..89d8a53 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -2235,7 +2235,7 @@ __PACKAGE__->register_method({ my $rootdir = PVE::LXC::mount_all($newid, $storecfg, $conf, 1); eval { - PVE::LXC::create_ifaces_ipams_ips($conf, $vmid); + PVE::LXC::create_ifaces_ipams_ips($conf, $newid); my $lxc_setup = PVE::LXC::Setup->new($conf, $rootdir); $lxc_setup->post_clone_hook($conf); }; -- 2.47.3