From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2E70D1FF13F for ; Thu, 07 May 2026 09:27:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0B490C99E; Thu, 7 May 2026 09:27:09 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH novnc] upgrade noVNC and patches to 1.7.0 Date: Thu, 7 May 2026 09:25:49 +0200 Message-ID: <20260507072628.599132-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4SBLJZK5GCPEQJT7BHQX7FXHVFOV2H6M X-Message-ID-Hash: 4SBLJZK5GCPEQJT7BHQX7FXHVFOV2H6M X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: drop the backport of f0a39cd (Fix appearance of extra key buttons) since it's included now. and refresh/rebase the patches (including some light whitespace fixes). Signed-off-by: Dominik Csapak --- needs an update of our novnc git mirror .../0001-add-PVE-specific-JS-code.patch | 6 +- ...002-add-custom-fbresize-event-on-rfb.patch | 10 ++-- ...nge-scaling-when-toggling-fullscreen.patch | 8 +-- debian/patches/0004-add-pve-style.patch | 8 +-- debian/patches/0005-remove-vnc-logos.patch | 2 +- ...rectory-for-fetching-images-js-files.patch | 4 +- .../patches/0007-add-pve-vnc-commands.patch | 2 +- ...add-replaceable-snippets-in-vnc.html.patch | 2 +- .../0009-decrease-animation-time.patch | 4 +- debian/patches/0010-use-only-app.js.patch | 2 +- .../0011-add-localCursor-setting-to-rfb.patch | 12 ++-- .../0012-pass-custom-command-to-vnc.patch | 2 +- ...ove-the-default-value-of-wsProtocols.patch | 8 +-- ...passing-deprecated-upgrade-parameter.patch | 2 +- ...-create-own-class-for-hidden-buttons.patch | 11 ++-- ...-button-on-isFullscreen-get-variable.patch | 2 +- debian/patches/0017-make-error-hideable.patch | 28 ++++----- ...ow-start-button-on-not-running-vm-ct.patch | 11 ++-- .../patches/0019-show-clipboard-button.patch | 2 +- ...-Fix-appearance-of-extra-key-buttons.patch | 60 ------------------- ...atch => 0020-use-generated-password.patch} | 3 + debian/patches/series | 3 +- novnc | 2 +- 23 files changed, 68 insertions(+), 126 deletions(-) delete mode 100644 debian/patches/0020-Fix-appearance-of-extra-key-buttons.patch rename debian/patches/{0021-use-generated-password.patch => 0020-use-generated-password.patch} (98%) diff --git a/debian/patches/0001-add-PVE-specific-JS-code.patch b/debian/patches/0001-add-PVE-specific-JS-code.patch index 926f0c0..f5bb262 100644 --- a/debian/patches/0001-add-PVE-specific-JS-code.patch +++ b/debian/patches/0001-add-PVE-specific-JS-code.patch @@ -453,7 +453,7 @@ index 0000000..1a062ad + }, +}; diff --git a/app/ui.js b/app/ui.js -index 51e57bd..bd1561c 100644 +index 8434a51..cba90b6 100644 --- a/app/ui.js +++ b/app/ui.js @@ -17,6 +17,7 @@ import keysyms from "../core/input/keysymdef.js"; @@ -562,7 +562,7 @@ index 51e57bd..bd1561c 100644 }, /* ------^------- -@@ -1729,9 +1750,36 @@ const UI = { +@@ -1751,9 +1772,36 @@ const UI = { /* ------^------- * /EXTRA KEYS * ============== @@ -638,5 +638,5 @@ index 82cacd5..458f4d0 100644
  • -- -2.39.5 +2.47.3 diff --git a/debian/patches/0002-add-custom-fbresize-event-on-rfb.patch b/debian/patches/0002-add-custom-fbresize-event-on-rfb.patch index 2fd12b0..86a504f 100644 --- a/debian/patches/0002-add-custom-fbresize-event-on-rfb.patch +++ b/debian/patches/0002-add-custom-fbresize-event-on-rfb.patch @@ -13,7 +13,7 @@ Signed-off-by: Dominik Csapak 2 files changed, 21 insertions(+) diff --git a/app/ui.js b/app/ui.js -index bd1561c..3726c8c 100644 +index cba90b6..18d7c36 100644 --- a/app/ui.js +++ b/app/ui.js @@ -1116,6 +1116,7 @@ const UI = { @@ -24,7 +24,7 @@ index bd1561c..3726c8c 100644 UI.rfb.clipViewport = UI.getSetting('view_clip'); UI.rfb.scaleViewport = UI.getSetting('resize') === 'scale'; UI.rfb.resizeSession = UI.getSetting('resize') === 'remote'; -@@ -1775,6 +1776,16 @@ const UI = { +@@ -1797,6 +1798,16 @@ const UI = { document.getElementById('pve_commands_button').classList.remove("noVNC_selected"); }, @@ -42,10 +42,10 @@ index bd1561c..3726c8c 100644 * /PVE * ============== diff --git a/core/rfb.js b/core/rfb.js -index e3266cc..23b436c 100644 +index 80011e4..4db6e73 100644 --- a/core/rfb.js +++ b/core/rfb.js -@@ -3014,6 +3014,16 @@ export default class RFB extends EventTargetMixin { +@@ -3010,6 +3010,16 @@ export default class RFB extends EventTargetMixin { this._updateClip(); this._updateScale(); @@ -63,5 +63,5 @@ index e3266cc..23b436c 100644 // Keep this size until browser client size changes -- -2.39.5 +2.47.3 diff --git a/debian/patches/0003-change-scaling-when-toggling-fullscreen.patch b/debian/patches/0003-change-scaling-when-toggling-fullscreen.patch index b51cddc..f519e16 100644 --- a/debian/patches/0003-change-scaling-when-toggling-fullscreen.patch +++ b/debian/patches/0003-change-scaling-when-toggling-fullscreen.patch @@ -12,10 +12,10 @@ Signed-off-by: Dominik Csapak 1 file changed, 11 insertions(+) diff --git a/app/ui.js b/app/ui.js -index 3726c8c..5773ddf 100644 +index 18d7c36..dbf5f96 100644 --- a/app/ui.js +++ b/app/ui.js -@@ -1334,6 +1334,13 @@ const UI = { +@@ -1356,6 +1356,13 @@ const UI = { } else if (document.msExitFullscreen) { document.msExitFullscreen(); } @@ -29,7 +29,7 @@ index 3726c8c..5773ddf 100644 } else { if (document.documentElement.requestFullscreen) { document.documentElement.requestFullscreen(); -@@ -1344,7 +1351,11 @@ const UI = { +@@ -1366,7 +1373,11 @@ const UI = { } else if (document.body.msRequestFullscreen) { document.body.msRequestFullscreen(); } @@ -42,5 +42,5 @@ index 3726c8c..5773ddf 100644 }, -- -2.39.5 +2.47.3 diff --git a/debian/patches/0004-add-pve-style.patch b/debian/patches/0004-add-pve-style.patch index d0f2592..dfa2685 100644 --- a/debian/patches/0004-add-pve-style.patch +++ b/debian/patches/0004-add-pve-style.patch @@ -10,14 +10,14 @@ and fix the z-index of the connect overlay Signed-off-by: Dominik Csapak --- - app/styles/pve.css | 46 ++++++++++++++++++++++++++++++++++++++++++++++ + app/styles/pve.css | 50 ++++++++++++++++++++++++++++++++++++++++++++++ vnc.html | 1 + - 2 files changed, 47 insertions(+) + 2 files changed, 51 insertions(+) create mode 100644 app/styles/pve.css diff --git a/app/styles/pve.css b/app/styles/pve.css new file mode 100644 -index 0000000..a312a95 +index 0000000..ce0c69b --- /dev/null +++ b/app/styles/pve.css @@ -0,0 +1,50 @@ @@ -84,5 +84,5 @@ index 458f4d0..2a50991 100644 -- -2.39.5 +2.47.3 diff --git a/debian/patches/0005-remove-vnc-logos.patch b/debian/patches/0005-remove-vnc-logos.patch index 98a4878..d15e3bf 100644 --- a/debian/patches/0005-remove-vnc-logos.patch +++ b/debian/patches/0005-remove-vnc-logos.patch @@ -46,5 +46,5 @@ index 2a50991..f5e4a81 100644 -- -2.39.5 +2.47.3 diff --git a/debian/patches/0006-change-source-directory-for-fetching-images-js-files.patch b/debian/patches/0006-change-source-directory-for-fetching-images-js-files.patch index 680f6ea..7277b3d 100644 --- a/debian/patches/0006-change-source-directory-for-fetching-images-js-files.patch +++ b/debian/patches/0006-change-source-directory-for-fetching-images-js-files.patch @@ -13,7 +13,7 @@ Signed-off-by: Dominik Csapak 2 files changed, 33 insertions(+), 34 deletions(-) diff --git a/app/ui.js b/app/ui.js -index 5773ddf..01c7c77 100644 +index dbf5f96..d9a8d52 100644 --- a/app/ui.js +++ b/app/ui.js @@ -58,7 +58,7 @@ const UI = { @@ -218,5 +218,5 @@ index f5e4a81..9f4fac0 100644 -- -2.39.5 +2.47.3 diff --git a/debian/patches/0007-add-pve-vnc-commands.patch b/debian/patches/0007-add-pve-vnc-commands.patch index ea01382..ee329be 100644 --- a/debian/patches/0007-add-pve-vnc-commands.patch +++ b/debian/patches/0007-add-pve-vnc-commands.patch @@ -41,5 +41,5 @@ index 9f4fac0..c9e166c 100644 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/app/styles/base.css b/app/styles/base.css -index 87bfb45..6e9b25d 100644 +index 33f0f35..fe96001 100644 --- a/app/styles/base.css +++ b/app/styles/base.css @@ -223,7 +223,7 @@ html { @@ -78,5 +78,5 @@ index 87bfb45..6e9b25d 100644 display: flex; opacity: 0; -- -2.39.5 +2.47.3 diff --git a/debian/patches/0010-use-only-app.js.patch b/debian/patches/0010-use-only-app.js.patch index 5e64eb8..d26c804 100644 --- a/debian/patches/0010-use-only-app.js.patch +++ b/debian/patches/0010-use-only-app.js.patch @@ -73,5 +73,5 @@ index 3c40c49..8ff6739 100644 -- -2.39.5 +2.47.3 diff --git a/debian/patches/0011-add-localCursor-setting-to-rfb.patch b/debian/patches/0011-add-localCursor-setting-to-rfb.patch index 62068c6..be2bdb4 100644 --- a/debian/patches/0011-add-localCursor-setting-to-rfb.patch +++ b/debian/patches/0011-add-localCursor-setting-to-rfb.patch @@ -15,7 +15,7 @@ Signed-off-by: Thomas Lamprecht 4 files changed, 41 insertions(+), 1 deletion(-) diff --git a/app/ui.js b/app/ui.js -index 01c7c77..0434fbc 100644 +index d9a8d52..7b998a0 100644 --- a/app/ui.js +++ b/app/ui.js @@ -192,6 +192,7 @@ const UI = { @@ -43,7 +43,7 @@ index 01c7c77..0434fbc 100644 UI.rfb.scaleViewport = UI.getSetting('resize') === 'scale'; UI.rfb.resizeSession = UI.getSetting('resize') === 'remote'; UI.rfb.qualityLevel = parseInt(UI.getSetting('quality')); -@@ -1802,6 +1806,12 @@ const UI = { +@@ -1824,6 +1828,12 @@ const UI = { * ============== * MISC * ------v------*/ @@ -57,7 +57,7 @@ index 01c7c77..0434fbc 100644 if (!UI.rfb) return; UI.rfb.viewOnly = UI.getSetting('view_only'); diff --git a/core/rfb.js b/core/rfb.js -index 23b436c..8260929 100644 +index 4db6e73..5cc2733 100644 --- a/core/rfb.js +++ b/core/rfb.js @@ -298,6 +298,7 @@ export default class RFB extends EventTargetMixin { @@ -67,8 +67,8 @@ index 23b436c..8260929 100644 + this._localCursor = false; this._showDotCursor = false; - if (options.showDotCursor !== undefined) { -@@ -368,6 +369,15 @@ export default class RFB extends EventTargetMixin { + +@@ -364,6 +365,15 @@ export default class RFB extends EventTargetMixin { } } @@ -155,5 +155,5 @@ index 8ff6739..f2c29af 100644