From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E82E51FF141 for ; Tue, 05 May 2026 11:14:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C45CB2098A; Tue, 5 May 2026 11:14:29 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH manager/network/proxmox-ve-rs v2 0/3] Expose OSPF Network-Type option Date: Tue, 5 May 2026 11:13:35 +0200 Message-ID: <20260505091342.106949-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777972320960 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [ospf.rs,frr.rs,lib.rs,area.rs,fabrics.pm] Message-ID-Hash: RVYEELXL5FL2DUKQCQMEZE7RFANMPUPK X-Message-ID-Hash: RVYEELXL5FL2DUKQCQMEZE7RFANMPUPK X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Previously the network-type option on OSPF interfaces was set to either point-to-point or broadcast, depending on if an ip address was configured on the interface. This is not enough, as some users want to have a switched network (e.g. switch) between their nodes, which calls for the point-to-multipoint network type. In order to uphold backwards-compatibility, make network-type an `Option`, where `None` will be the "automatic" network-type selection we had before. ┌──────────┐ ┌──────────────┐ ┌───────────────────┐ ┌───┐ │None(auto)│ │Point-to-Point│ │Point-to-Multipoint│ │...│ └────┬─────┘ └──────────────┘ └───────────────────┘ └───┘ │ ▼ ┌─────────────────┐ │Is there an ip │ │on the interface?│ └──┬────────────┬─┘ │no │yes ▼ ▼ ┌──────────────┐ ┌────────────────────────┐ │Point-to-Point│ │No FRR network statement│ └──────────────┘ └───────────┬────────────┘ │ ▼ ┌────────────────────────────┐ │FRR selects either Broadcast│ │Point-to-Point or Loopback │ │(internal network-type) │ └────────────────────────────┘ This series is based on the s.hanreich/pve-dci branch. Changelog v1: * rebased proxmox-ve-rs: Gabriel Goller (1): fabrics: ospf: expose network-type interface property proxmox-frr/src/ser/ospf.rs | 20 +-------------- proxmox-sdn-types/src/lib.rs | 2 +- proxmox-sdn-types/src/{area.rs => ospf.rs} | 25 +++++++++++++++++++ proxmox-ve-config/src/sdn/fabric/frr.rs | 13 +++++++--- .../fabric/section_config/protocol/ospf.rs | 8 +++++- 5 files changed, 43 insertions(+), 25 deletions(-) rename proxmox-sdn-types/src/{area.rs => ospf.rs} (65%) pve-network: Gabriel Goller (1): fabrics: add ospf network_type property to interfaces src/PVE/Network/SDN/Fabrics.pm | 11 +++++++++++ 1 file changed, 11 insertions(+) pve-manager: Gabriel Goller (1): fabrics: ospf: add network-type property in interface panel .../sdn/fabrics/ospf/InterfacePanel.js | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) Summary over all repositories: 7 files changed, 103 insertions(+), 25 deletions(-) -- Generated by murpp 0.11.0